Fix raise NotImplemented to raise NotImplementedError in wrap_llm_lora#1259
Open
Mr-Neutr0n wants to merge 1 commit intoOpenGVLab:mainfrom
Open
Fix raise NotImplemented to raise NotImplementedError in wrap_llm_lora#1259Mr-Neutr0n wants to merge 1 commit intoOpenGVLab:mainfrom
Mr-Neutr0n wants to merge 1 commit intoOpenGVLab:mainfrom
Conversation
`NotImplemented` is a built-in constant intended for use in rich comparison methods, not an exception. Raising it directly produces a confusing `TypeError: exceptions must derive from BaseException` instead of the expected `NotImplementedError`. This change fixes the error in `wrap_llm_lora()` to properly raise `NotImplementedError` with a descriptive message showing which architecture was unsupported.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NotImplementedis a built-in constant used for rich comparison methods, not an exception class. Raising it directly produces a confusingTypeError: exceptions must derive from BaseExceptioninstead of the expectedNotImplementedError.elsebranch inwrap_llm_lora()to properlyraise NotImplementedErrorwith a descriptive message indicating which LLM architecture is unsupported.Before (broken):
After (fixed):
Test plan
raise NotImplementedproducesTypeErrorin Python