Feature: add a new event for many-to-many relationships#498
Open
andrestejerina97 wants to merge 1 commit intomainfrom
Open
Feature: add a new event for many-to-many relationships#498andrestejerina97 wants to merge 1 commit intomainfrom
andrestejerina97 wants to merge 1 commit intomainfrom
Conversation
andrestejerina97
force-pushed
the
feature/new-event-for-formatters
branch
2 times, most recently
from
ffb0da8 to
e142976
Compare
andrestejerina97
force-pushed
the
feature/new-event-for-formatters
branch
2 times, most recently
from
e5584c1 to
1613295
Compare
andrestejerina97
force-pushed
the
feature/new-event-for-formatters
branch
from
1613295 to
bd0d027
Compare
Contributor
Author
|
@martinquiroga-exo ready to review |
martinquiroga-exo
approved these changes
Feb 18, 2026
| ]; | ||
|
|
||
| $eventType = $isManyToMany | ||
| ? ($isDeletion ? IAuditStrategy::EVENT_COLLECTION_MANYTOMANY_DELETE : IAuditStrategy::EVENT_COLLECTION_MANYTOMANY_UPDATE) |
Contributor
There was a problem hiding this comment.
Not sure about this concatenated ternary operators, perhaps I would like to see an exit early guard clause when the event is an EVENT_COLLECTION_UPDATE.
I defer to Casey on this one since is a design issue rather than an implementation one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: https://app.clickup.com/t/86b84w9x2