Skip to content

[gd32][i2c]Add an example for measuring the onboard peripherals of the I2C board#11161

Open
CXSforHPU wants to merge 1 commit intoRT-Thread:masterfrom
CXSforHPU:gd32
Open

[gd32][i2c]Add an example for measuring the onboard peripherals of the I2C board#11161
CXSforHPU wants to merge 1 commit intoRT-Thread:masterfrom
CXSforHPU:gd32

Conversation

@CXSforHPU
Copy link
Contributor

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

添加i2c板载外设测设用例

你的解决方案是什么 (what is your solution)

修改board目录下的kcoinfig,并添加port文件夹,增加Sconscript脚本

请提供验证的bsp和config (provide the config and bsp)

  • BSP:
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/ALL_BSP_COMPILE.json 详细请参考链接BSP自查

@github-actions
Copy link

👋 感谢您对 RT-Thread 的贡献!Thank you for your contribution to RT-Thread!

为确保代码符合 RT-Thread 的编码规范,请在你的仓库中执行以下步骤运行代码格式化工作流(如果格式化CI运行失败)。
To ensure your code complies with RT-Thread's coding style, please run the code formatting workflow by following the steps below (If the formatting of CI fails to run).


🛠 操作步骤 | Steps

  1. 前往 Actions 页面 | Go to the Actions page
    点击进入工作流 → | Click to open workflow →

  2. 点击 Run workflow | Click Run workflow

  • 设置需排除的文件/目录(目录请以"/"结尾)
    Set files/directories to exclude (directories should end with "/")
  • 将目标分支设置为 \ Set the target branch to:gd32
  • 设置PR number为 \ Set the PR number to:11161
  1. 等待工作流完成 | Wait for the workflow to complete
    格式化后的代码将自动推送至你的分支。
    The formatted code will be automatically pushed to your branch.

完成后,提交将自动更新至 gd32 分支,关联的 Pull Request 也会同步更新。
Once completed, commits will be pushed to the gd32 branch automatically, and the related Pull Request will be updated.

如有问题欢迎联系我们,再次感谢您的贡献!💐
If you have any questions, feel free to reach out. Thanks again for your contribution!

@github-actions github-actions bot added BSP BSP: GD32 BSP related with GD32 labels Jan 31, 2026
@CXSforHPU
Copy link
Contributor Author

CXSforHPU commented Jan 31, 2026

此版本依赖以下pr
RT-Thread/packages#1965
XiaojieFan/at24cxx#23

@CXSforHPU
Copy link
Contributor Author

新提交pr做了以下修改

修改目的 修改文件
增加prot文件夹并修改sconscript脚本来支持外设文件的编译 board/sconscript;board/port/sconscript
修改了board文件夹下的kconfig来支持进行选择外设 board/kconfig
修改链接脚本来支持utest的使用 linker.lds
支持初始化板载外设并进行检查的流程 [board/port/at24c02/at24c02.c]
能够引出自动初始化后的设备指针 board/port/at24c02/at24c02.h
使用utest框架进行测试外设 board/port/at23c02/test_at24c02.c

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds an AT24C02 (I2C EEPROM) port/example for the gd32vw553h-eval BSP, wiring it into Kconfig/SCons and enabling utest testcase discovery via the linker script.

Changes:

  • Add AT24C02 utest testcase and optional device init hook under board/port/at24c02/.
  • Integrate the new port folder into the BSP build system (SConscript) and expose Kconfig options.
  • Update the linker script to include the UtestTcTab section so utest can enumerate testcases on this BSP.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
bsp/gd32/risc-v/gd32vw553h-eval/board/port/at24c02/test_at24c02.c Adds utest testcase for AT24C02 read/write/check
bsp/gd32/risc-v/gd32vw553h-eval/board/port/at24c02/at24c02.h Adds shared AT24C02 config macros and global handle declaration
bsp/gd32/risc-v/gd32vw553h-eval/board/port/at24c02/at24c02.c Adds INIT_DEVICE_EXPORT-based init/check path
bsp/gd32/risc-v/gd32vw553h-eval/board/port/SConscript Adds build integration for the new port module and optional utest/init sources
bsp/gd32/risc-v/gd32vw553h-eval/board/SConscript Auto-includes child SConscript files (e.g., port/SConscript)
bsp/gd32/risc-v/gd32vw553h-eval/board/Kconfig Adds Kconfig options to enable AT24C02, its utest, and init
bsp/gd32/risc-v/gd32vw553h-eval/board/linker_scripts/link.lds Adds UtestTcTab section bounds so utest discovery works

Comment on lines +111 to +114
menuconfig BSP_USING_AT24C02
bool "Enable AT24C02 I2C0( SCL[PA2 : 2] SDA[PA3 : 3] )"
default n
select PKG_USING_AT24CXX
Copy link

Copilot AI Feb 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[discrepancy_with_pr_description/与PR描述不一致]: PR description template fields appear unfilled

English: The PR description still contains the required template block and does not provide the requested verification info (BSP path, .config changes, action link) or status checkboxes. Please update the PR description so reviewers can reproduce and verify this BSP example.
中文:PR 描述中仍保留了必填模板块,且未补充要求的验证信息(BSP 路径、.config 改动、action 编译链接)以及状态勾选项。请完善 PR 描述,方便复现和验证该 BSP 示例。

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BSP: GD32 BSP related with GD32 BSP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants