Fix union field access by representing unions as structs#269
Draft
LegNeato wants to merge 1 commit intoRust-GPU:mainfrom
Draft
Fix union field access by representing unions as structs#269LegNeato wants to merge 1 commit intoRust-GPU:mainfrom
LegNeato wants to merge 1 commit intoRust-GPU:mainfrom
Conversation
Collaborator
Author
|
@simensgreen can you check this fix? |
Firestar99
reviewed
Jun 3, 2025
When a union has multiple fields, represent it as a struct with all fields at offset 0 instead of just using the largest field. This allows pointer casts between union fields to work correctly by enabling the recover_access_chain_from_offset function to find valid access chains. Fixes Rust-GPU#241.
Firestar99
approved these changes
Jun 4, 2025
|
@LegNeato Ok, in this simple example it works, but in a more complicated scenario, it will not. Now I can reproduce both Full error messages: |
Firestar99
requested changes
Jun 4, 2025
Member
Firestar99
left a comment
There was a problem hiding this comment.
blocked by #270 due to adding a test
Collaborator
Author
|
Ok, this code is a minefield...back to the drawingboard ha. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a union has multiple fields, represent it as a struct with all fields at offset 0 instead of just using the largest field. This allows pointer casts between union fields to work correctly by enabling the recover_access_chain_from_offset function to find valid access chains.
Fixes #241.