Removed inappropriate repository dependencies

[PetrilloAtWork]

An "obj" package is designed to make ROOT understand LArSoft data objects, and it needs the minimum possible dependencies. In particular, is expected to depend only on other "obj" packages, no "alg" or art-dependent packages.
sbnobj did not fulfil that requirement; one side effect is that attempting to load sbn::crt::CRTHit or other objects from sbnobj/Common/CRT fails:

root [0] sbn::crt::CRTHit hit;                                                                                                    /cvmfs/larsoft.opensciencegrid.org/products/root/v6_28_12/Linux64bit+3.10-2.17-e26-p3915-prof/etc/cling/std.modulemap:312:10: erro
r: module 'std.span' requires feature 'cplusplus20'                                                                                 module "span" {                                                                                                                 
         ^                                                                                                                        
/cvmfs/larsoft.opensciencegrid.org/products/range/v3_0_12_0/include/range/v3/range/concepts.hpp:25:10: note: submodule of top-leve
l module 'std' implicitly imported here                                                                                           
#include <span>                                                                                                                   
         ^                                                                                                                        
/cvmfs/larsoft.opensciencegrid.org/products/root/v6_28_12/Linux64bit+3.10-2.17-e26-p3915-prof/etc/cling/std.modulemap:312:10: erro
r: module 'std.span' requires feature 'cplusplus20'                                                                               
  module "span" {                                                                                                                 
         ^                                                                                                                        
/cvmfs/larsoft.opensciencegrid.org/products/range/v3_0_12_0/include/range/v3/range/access.hpp:27:10: note: submodule of top-level 
module 'std' implicitly imported here                                                                                             
#include <span>                                                                                                                   
         ^                                                                                                                        

The reason is ROOT Cling interpreter trying to load algorithm code, which pulls ranve-v3 library in, and Cling can't parse it (yet — maybe enabling C++20 it could).

The changes in this commit conform sbnobj to that requirement.

This PR requires lardataobj v10_04_00, first merged in LArSoft v10_15_00 (because of LArSoft issue #30090).

Reviewers: the changes are of technical nature, no actual change is expected.
However, dependencies unnecessary to sbnobj have been removed, and it is possible that some packages that were (incorrectly) not declaring those dependencies will now fail to compile. In that case, those packages need to be fixed as well.
So, asking a review from somebody with fingers into the build.

[Copilot]

Pull request overview

This PR removes inappropriate dependencies from sbnobj to ensure it depends only on "obj" packages (not "alg" or art-dependent packages), which fixes ROOT Cling interpreter issues when loading certain data objects like sbn::crt::CRTHit.

Key changes include:

• Removed dependencies on art framework, larcorealg, lardataalg, larcore, and lardata packages
• Replaced util::quantities::tick::value_t with std::ptrdiff_t to avoid pulling in lardataalg
• Changed library dependency visibility from PRIVATE to PUBLIC where appropriate
• Cleaned up duplicate and unnecessary includes in dictionary headers

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
CMakeLists.txt	Removed art, larcore, larcorealg, lardataalg, and lardata dependencies; added clarifying comment that package must not depend on art or *alg packages
sbnobj/ICARUS/TPC/CMakeLists.txt	Changed dependencies from PRIVATE to PUBLIC visibility; removed unnecessary dictionary library dependencies
sbnobj/ICARUS/PMT/Trigger/Data/OpticalTriggerGate.h	Replaced lardataalg tick type with std::ptrdiff_t to eliminate dependency
sbnobj/ICARUS/PMT/Trigger/Data/CMakeLists.txt	Removed lardataalg and larcorealg dependencies
sbnobj/Common/Utilities/CMakeLists.txt	Removed art framework and geometry dependencies unnecessary for data object library
sbnobj/Common/Reco/CMakeLists.txt	Removed larcorealg::Geometry dependency
sbnobj/Common/CRT/classes.h	Cleaned up duplicate includes and reordered headers
sbnobj/Common/CRT/CRTHitT0TaggingInfo.hh	Removed unnecessary geometry-related includes
sbnobj/Common/CRT/CMakeLists.txt	Replaced larcorealg::Geometry with larcoreobj::geo_vectors

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

There's an inconsistency in spacing after "find_package(" compared to the line below. The original code had consistent spacing, but line 38 now has a space after the opening parenthesis while line 39 does not. Consider making the spacing consistent for better code style.

Suggested change

	find_package( canvas REQUIRED EXPORT)
	find_package(canvas REQUIRED EXPORT)

[PetrilloAtWork]

It's consistent with all the other existing lines, so it stays.

[kjplows]

Thanks Gianluca! So, to be on the safe side, testing this change should (I'll reckon) involve running mrb t on sbndcode and icaruscode built against this sbnobj + larsoft v10_15+ .. Worth seeing what the stack does!

[PetrilloAtWork]

Yes, I think mrb test will give confidence. Even just mrb build would.

[hgreenlee]

This PR has merge conflicts with PR 150, which are easily resolved. I did a full build+test with both PRs (150 and 159) with sbncode and icaruscode.

[kjplows]

Approved given tests @hgreenlee did

[kjplows]

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_15_00 SBNSoftware/sbndaq-artdaq-core@v1_10_06 SBNSoftware/sbn*@SBN_SUITE_v10_15_00

[FNALbuild]

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

[FNALbuild]

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

[FNALbuild]

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

[FNALbuild]

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

[FNALbuild]

❌ CI build for SBND Failed at phase ci_tests SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

[FNALbuild]

⚠️ CI build for ICARUS Warning at phase ci_tests ICARUS on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard