Skip to content

Mirror source tree for adapter headers#260

Open
hgangwar wants to merge 6 commits intoSCOREC:developfrom
hgangwar:mirror_src
Open

Mirror source tree for adapter headers#260
hgangwar wants to merge 6 commits intoSCOREC:developfrom
hgangwar:mirror_src

Conversation

@hgangwar
Copy link

Install adapter headers via DIRECTORY install.

Changes

  • Defined ADAPTER_HEADERS.
  • Installed headers from ADAPTER_HEADERS into their respective directories.
  • Included create_field.h in examples for external-usage-example usage testing.

@hgangwar
Copy link
Author

@jacobmerson

@jacobmerson
Copy link
Collaborator

We had a breif discussion offline. We are going to investigate converting our header definitions over to FILE_SETS which should maintain the structure.

https://cmake.org/cmake/help/latest/command/install.html#id5

This approach looks like it may also enable us to set up targets that check that the header files can be correctly included, which would be a nice test to include to our CI/CD testing.

https://cmake.org/cmake/help/latest/prop_tgt/VERIFY_INTERFACE_HEADER_SETS.html#prop_tgt:VERIFY_INTERFACE_HEADER_SETS

Copy link
Collaborator

@jacobmerson jacobmerson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hgangwar this looks good. Are there other header lists that should be converted to use this method? If so, lets implement that and then make this PR not a draft.

@hgangwar
Copy link
Author

hgangwar commented Mar 4, 2026

Added field_layout_communicator.h to PCMS_HEADERS, required by field_communicator2.h.

Gangwar added 2 commits March 4, 2026 19:06
Syncing with the upstream develop, adding uniform grid adapter
@jacobmerson
Copy link
Collaborator

I will merge when remaining headers are added to respective FILE_SET so we have a consistent handling of headers in our CMake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants