Skip to content

Fix shadowenv trust error in new git worktrees#6820

Open
kdaviduik wants to merge 1 commit intomainfrom
kd-fix-shadowenv-bug
Open

Fix shadowenv trust error in new git worktrees#6820
kdaviduik wants to merge 1 commit intomainfrom
kd-fix-shadowenv-bug

Conversation

@kdaviduik
Copy link
Contributor

WHY are these changes introduced?

When developers create new git worktrees in this repo, they see:

░shadowenv failure: directory: '.../.shadowenv.d' contains untrusted shadowenv program

This doesn't happen in other Shopify repos. The root cause: .shadowenv.d/yarn.lisp was committed to git (added in 2022 for acceptance tests), but shadowenv trust files are user-specific and not committed. New worktrees get the lisp file but no trust → error.

WHAT is this pull request doing?

Removes the committed shadowenv files and adds .shadowenv.d/ to .gitignore as a safeguard.

File Action Reason
.shadowenv.d/yarn.lisp Delete Root cause of trust error
.shadowenv.d/.gitignore Delete Was keeping yarn.lisp tracked
bin/shadowenv/yarn Delete Yarn deprecation warning (pnpm migration done in 2022)
bin/shadowenv/p Delete pnpm alias (just type pnpm directly)
.gitignore Edit Add .shadowenv.d/ to prevent reintroduction

Going forward, dev up will generate shadowenv files as needed and handle trust automatically.

How to test your changes?

  1. Create a new worktree: git worktree add ../test-worktree main
  2. cd ../test-worktree
  3. Confirm no shadowenv trust error appears
  4. Run dev up - should work normally
  5. Clean up: git worktree remove ../test-worktree

Measuring impact

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

Why: When developers created new git worktrees, they encountered:
  "shadowenv failure: directory '.shadowenv.d' contains untrusted shadowenv program"

This happened because .shadowenv.d/yarn.lisp was committed to the repo, but
shadowenv trust files are user-specific and not tracked by git. New worktrees
got the lisp file but no trust, causing the error.

How: Remove the committed shadowenv files and add .shadowenv.d/ to .gitignore.
The yarn deprecation wrapper and pnpm alias scripts are no longer needed since
the pnpm migration completed in 2022. Going forward, `dev up` will generate
shadowenv files as needed and handle trust automatically.

Files removed:
- .shadowenv.d/yarn.lisp (shadowenv config)
- .shadowenv.d/.gitignore (kept yarn.lisp tracked)
- bin/shadowenv/yarn (yarn deprecation warning)
- bin/shadowenv/p (pnpm alias)
@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2026

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
79.67% (+0.44% 🔼)
14454/18142
🟡 Branches
74% (+0.89% 🔼)
7173/9693
🟡 Functions
79.79% (+0.42% 🔼)
3687/4621
🟢 Lines
80.04% (+0.45% 🔼)
13666/17075
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🟢
... / admin-as-app.ts
100% 100% 100% 100%
🟢
... / metafield_definitions.ts
100% 100% 100% 100%
🟢
... / metaobject_definitions.ts
100% 100% 100% 100%
🟢
... / bulk-operation-cancel.ts
100% 100% 100% 100%
🟢
... / bulk-operation-run-mutation.ts
100% 100% 100% 100%
🟢
... / bulk-operation-run-query.ts
100% 100% 100% 100%
🟢
... / get-bulk-operation-by-id.ts
100% 100% 100% 100%
🟢
... / list-bulk-operations.ts
100% 100% 100% 100%
🟢
... / staged-uploads-create.ts
100% 100% 100% 100%
🟢
... / fetch_store_by_domain.ts
100% 100% 100% 100%
🟢
... / organization_exp_flags.ts
100% 100% 100% 100%
🔴
... / import-custom-data-definitions.ts
0% 100% 0% 0%
🔴
... / cancel.ts
0% 100% 0% 0%
🔴
... / execute.ts
0% 0% 0% 0%
🔴
... / status.ts
0% 0% 0% 0%
🔴
... / pull.ts
0% 100% 0% 0%
🟡
... / execute-operation.ts
75.68% 50% 100% 75.68%
🔴
... / pull.ts
0% 0% 0% 0%
🟢
... / bulk-operation-status.ts
96.55% 92.11% 100% 100%
🟢
... / cancel-bulk-operation.ts
100% 100% 100% 100%
🟢
... / constants.ts
100% 100% 100% 100%
🟢
... / download-bulk-operation-results.ts
100% 100% 100% 100%
🟢
... / execute-bulk-operation.ts
87.14% 83.67% 100% 88.41%
🟢
... / format-bulk-operation-status.ts
100% 100% 100% 100%
🟢
... / run-mutation.ts
100% 100% 100% 100%
🟢
... / run-query.ts
100% 100% 100% 100%
🟡
... / stage-file.ts
73.53% 62.5% 85.71% 72.73%
🟢
... / watch-bulk-operation.ts
100% 94.74% 100% 100%
🟢
... / utilities.ts
100% 100% 100% 100%
🟢
... / declarative-definitions.ts
98.54% 93.18% 100% 98.51%
🟢
... / common.ts
97.62% 95% 100% 97.06%
🟢
... / execute-command-helpers.ts
100% 100% 100% 100%
🟢
... / file-formatter.ts
100% 100% 100% 100%
🔴
... / promiseWithResolvers.ts
33.33% 50% 50% 33.33%
🟢
... / theme-listing.ts
100% 100% 100% 100%
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🔴
... / execute.ts
0%
0% (-100% 🔻)
0% 0%
🟢
... / loader.ts
94.06% (+0.2% 🔼)
86.41% (-0.42% 🔻)
97.17% (+0.11% 🔼)
94.85% (+0.18% 🔼)
🟢
... / extension-instance.ts
84.8% (+0.23% 🔼)
77.6% (-0.91% 🔻)
92.06% (+0.13% 🔼)
85.11% (+0.24% 🔼)
🟡
... / specification.ts
69.64% (+0.55% 🔼)
75.61% (+2.44% 🔼)
76.47% (-1.31% 🔻)
69.39% (+0.64% 🔼)
🟢
... / ui_extension.ts
88.61% (-6.22% 🔻)
78.57% (-2.68% 🔻)
85.19% (-14.81% 🔻)
90.79% (-5.67% 🔻)
🟢
... / store-context.ts
100%
82.35% (-0.98% 🔻)
100% 100%
🟢
... / Logs.tsx
90%
90.91% (-5.97% 🔻)
100% 90%
🟢
... / fetch.ts
84.21% (+0.88% 🔼)
82.35% (-0.98% 🔻)
75%
85.29% (+1.42% 🔼)
🟢
... / app-event-watcher-handler.ts
86.36% (-4.11% 🔻)
75% 86.67%
85.71% (-5.19% 🔻)
🟡
... / middlewares.ts
77.33% (-0.87% 🔻)
75%
68.42% (-1.58% 🔻)
76.39% (-0.94% 🔻)
🔴
... / server.ts
1.23% (-0.02% 🔻)
0% 0%
1.3% (-0.02% 🔻)
🟢
... / setup-dev-processes.ts
93.62% (+0.14% 🔼)
66.67% (-4.76% 🔻)
90%
92.86% (+0.17% 🔼)
🟢
... / bundle.ts
93.22%
63.33% (-3.33% 🔻)
94.12% (+5.88% 🔼)
96.3%
🟢
... / developer-platform-client.ts
84.62% (-1.5% 🔻)
71.43% (+0.84% 🔼)
81.82% (+1.82% 🔼)
93.75% (+0.42% 🔼)
🔴
... / http-reverse-proxy.ts
58.97% (-4.91% 🔻)
37.04% (-2.96% 🔻)
58.33% (-5.3% 🔻)
59.46% (-5.25% 🔻)
🟢
... / api.ts
87.07% (-0.43% 🔻)
76.71% (-0.1% 🔻)
100%
86.49% (-0.43% 🔻)
🟢
... / device-authorization.ts
88.24% (-0.83% 🔻)
76.47% (-2.94% 🔻)
100%
88.24% (-0.83% 🔻)
🟢
... / SingleTask.tsx
84.21% (-15.79% 🔻)
50% (-50% 🔻)
80% (-20% 🔻)
84.21% (-15.79% 🔻)
🔴
... / environment.ts
35% (-5% 🔻)
41.18%
40% (-10% 🔻)
36.84% (-5.26% 🔻)
🔴
... / ui.tsx
50.82% (-0.79% 🔻)
42.86% (-5.53% 🔻)
54.55% (+1.42% 🔼)
50% (-0.82% 🔻)
🟢
... / console.ts
81.82% (+15.15% 🔼)
75% (-25% 🔻)
100% (+33.33% 🔼)
81.82% (+15.15% 🔼)
🟢
... / init.ts
88% (-0.89% 🔻)
71.43% (+4.76% 🔼)
86.67% (+4.85% 🔼)
88% (-0.89% 🔻)
🟢
... / storefront-renderer.ts
90.2% (-0.54% 🔻)
78.95%
81.82% (-1.52% 🔻)
90.2% (-0.54% 🔻)
🟡
... / theme-polling.ts
67.57% (-0.49% 🔻)
68.75% 78.57%
66.18% (-1.47% 🔻)

Test suite run success

3718 tests passing in 1438 suites.

Report generated by 🧪jest coverage report action from b800136

@kdaviduik kdaviduik marked this pull request as ready for review February 5, 2026 17:30
@kdaviduik kdaviduik requested a review from a team as a code owner February 5, 2026 17:30
@kdaviduik kdaviduik requested a review from a team February 5, 2026 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants