Zigbee Switch: Add support/handling for Stateless Step Capabilities by wkhenon · Pull Request #2818 · SmartThingsCommunity/SmartThingsEdgeDrivers

wkhenon · 2026-03-02T21:53:08Z

Check all that apply

Type of Change

WWST Certification Request
- If this is your first time contributing code:
  - I have reviewed the README.md file
  - I have reviewed the CODE_OF_CONDUCT.md file
  - I have signed the CLA
- I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
Bug fix
New feature
Refactor

Checklist

I have performed a self-review of my code
I have commented my code in hard-to-understand areas
I have verified my changes by testing with a device or have communicated a plan for testing
I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Summary of Completed Tests

github-actions · 2026-03-02T21:54:26Z

Invitation URL:
https://bestow-regional.api.smartthings.com/invite/RBlEbJ99NvjE

github-actions · 2026-03-02T21:57:32Z

Test Results

0 tests 0 ✅ 0s ⏱️
0 suites 0 💤
0 files 0 ❌

Results for commit 671071f.

♻️ This comment has been updated with latest results.

github-actions · 2026-03-02T21:57:34Z

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 671071f

github-actions · 2026-03-03T15:59:19Z

Duplicate profile check: Warning - duplicate profiles detected.
color-temp-bulb-2700K-6500K.yml == color-temp-bulb.yml

drivers/SmartThings/zigbee-switch/src/stateless_handlers/init.lua

hcarter-775 · 2026-03-09T15:18:24Z

drivers/SmartThings/zigbee-switch/src/stateless_handlers/init.lua

+    local min_mireds = capabilities.colorTemperature.colorTemperatureRange.minimum or COLOR_TEMPERATURE_MIRED_MIN -- default min mireds
+    local max_mireds = capabilities.colorTemperature.colorTemperatureRange.maximum or COLOR_TEMPERATURE_MIRED_MAX -- default max mireds


Isn't the colorTemperatureRange defined in kelvin? Since these are handled in mireds I believe these need to be converted. Also, the values of colorTemperatureRange are required in the capability definition, so doing it this way I do not think we'd need an "or" case

Also (could be mistaken) but I think this implementation cannot be matched today in the native handlers, so if we want to map this, we'll have to use the previous get_field implementation. I don't really know what should be done with that but calling it out now.

drivers/SmartThings/zigbee-switch/src/stateless_handlers/init.lua

- get calues from `colorTemperature` `range` - local values for constants

- fix conversions - swap `min` and `max` - add fail through condition in case the device incorrectly supports `colorTemperature`

- simplify `CcStepMode`

greens · 2026-03-11T21:09:09Z

drivers/SmartThings/zigbee-switch/src/stateless_handlers/init.lua

+    local kelvin_min = device:get_field(switch_utils.KELVIN_MIN);
+    local kelvin_max = device:get_field(switch_utils.KELVIN_MAX);


these are only used to store one value until we get the second, the range attribute's value should be considered canonical over these.

drivers/SmartThings/zigbee-switch/src/stateless_handlers/can_handle.lua

- fix tab spacing - back out driver test changes (covered by #2773) - swap `color_temp_range` and `kelvin_min, kelvin_max` checks

wkhenon changed the base branch from main to feature/color_temp_range March 2, 2026 21:53

wkhenon force-pushed the zigbee-switch/stateless-capabilities branch 2 times, most recently from 535962c to cf1fc47 Compare March 3, 2026 15:24

greens force-pushed the feature/color_temp_range branch from 3d5baa4 to 8855768 Compare March 3, 2026 21:17

wkhenon force-pushed the zigbee-switch/stateless-capabilities branch 2 times, most recently from c0a48c5 to f4a7af9 Compare March 4, 2026 17:26

wkhenon requested review from aleclorimer, cjswedes, greens, hcarter-775, nickolas-deboom, pegor-karoglanian and tpmanley March 4, 2026 17:55

Base automatically changed from feature/color_temp_range to main March 4, 2026 19:07

greens reviewed Mar 4, 2026

View reviewed changes

drivers/SmartThings/zigbee-switch/src/stateless_handlers/init.lua Outdated Show resolved Hide resolved

wkhenon force-pushed the zigbee-switch/stateless-capabilities branch from f10a277 to 1bbafc5 Compare March 9, 2026 14:30

hcarter-775 reviewed Mar 9, 2026

View reviewed changes

wkhenon force-pushed the zigbee-switch/stateless-capabilities branch from 1bbafc5 to 21d5850 Compare March 9, 2026 20:23

greens reviewed Mar 10, 2026

View reviewed changes

drivers/SmartThings/zigbee-switch/src/stateless_handlers/init.lua Outdated Show resolved Hide resolved

hcarter-775 reviewed Mar 11, 2026

View reviewed changes

drivers/SmartThings/zigbee-switch/src/stateless_handlers/init.lua Outdated Show resolved Hide resolved

wkhenon added 5 commits March 11, 2026 15:03

CHAD-17426: Add stateless step capabilities to zigbee-switch

a55ba69

pr comments pt.1

138d84d

- get calues from `colorTemperature` `range` - local values for constants

pr comments pt.2

945c742

- fix conversions - swap `min` and `max` - add fail through condition in case the device incorrectly supports `colorTemperature`

pr comments. pt. 3

754ff0b

- simplify `CcStepMode`

move consts to switch_utils

75ef0dc

wkhenon force-pushed the zigbee-switch/stateless-capabilities branch from 4ad4ca3 to 75ef0dc Compare March 11, 2026 19:24

wkhenon added 2 commits March 11, 2026 16:07

gate failing tests on api_version = 20

7940ac5

update min_mireds and max_mireds handling

7640412

greens reviewed Mar 11, 2026

View reviewed changes

drivers/SmartThings/zigbee-switch/src/stateless_handlers/can_handle.lua Outdated Show resolved Hide resolved

pr comments pt. 4

671071f

- fix tab spacing - back out driver test changes (covered by #2773) - swap `color_temp_range` and `kelvin_min, kelvin_max` checks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Zigbee Switch: Add support/handling for Stateless Step Capabilities#2818

Zigbee Switch: Add support/handling for Stateless Step Capabilities#2818
wkhenon wants to merge 8 commits intomainfrom
zigbee-switch/stateless-capabilities

wkhenon commented Mar 2, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Mar 2, 2026

Uh oh!

github-actions bot commented Mar 2, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Mar 2, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Mar 3, 2026

Uh oh!

Uh oh!

hcarter-775 Mar 9, 2026 •

edited

Loading

Uh oh!

hcarter-775 Mar 9, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

greens Mar 11, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		local min_mireds = capabilities.colorTemperature.colorTemperatureRange.minimum or COLOR_TEMPERATURE_MIRED_MIN -- default min mireds
		local max_mireds = capabilities.colorTemperature.colorTemperatureRange.maximum or COLOR_TEMPERATURE_MIRED_MAX -- default max mireds

		local kelvin_min = device:get_field(switch_utils.KELVIN_MIN);
		local kelvin_max = device:get_field(switch_utils.KELVIN_MAX);

Conversation

wkhenon commented Mar 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Type of Change

Checklist

Description of Change

Summary of Completed Tests

Uh oh!

github-actions bot commented Mar 2, 2026

Uh oh!

github-actions bot commented Mar 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

github-actions bot commented Mar 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Mar 3, 2026

Uh oh!

Uh oh!

hcarter-775 Mar 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hcarter-775 Mar 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

greens Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

wkhenon commented Mar 2, 2026 •

edited

Loading

github-actions bot commented Mar 2, 2026 •

edited

Loading

github-actions bot commented Mar 2, 2026 •

edited

Loading

hcarter-775 Mar 9, 2026 •

edited

Loading

hcarter-775 Mar 9, 2026 •

edited

Loading