Skip to content

Revamp graph store integration tests#547

Merged
kmontemayor2-sc merged 5 commits intomainfrom
kmonte/revamp-gs-integration
Mar 24, 2026
Merged

Revamp graph store integration tests#547
kmontemayor2-sc merged 5 commits intomainfrom
kmonte/revamp-gs-integration

Conversation

@kmontemayor2-sc
Copy link
Collaborator

@kmontemayor2-sc kmontemayor2-sc commented Mar 16, 2026

Scope of work done

The below changes accomplish two things:

  1. Bring test time down from ~1000s to 500s (due to larger batch size
  2. Makes the test less brittle on batch size.
  • Simplified graph_store_integration_test.py by reducing indirection and eliminating duplicated code, cutting the file from 1286 to 1072 lines (17% reduction)
  • Extracted _to_long_cpu() as a single normalization point, removing redundant .detach().cpu().to(dtype=torch.long) calls scattered across multiple helper functions
  • Inlined 4 single-use or trivial wrapper functions (_flatten_sampler_input, _flatten_ablp_anchor_nodes, _gather_all_rank_seeds, _gather_unique_compute_node_expected_seeds) into their callers
  • Unified 3 near-identical client process functions (_client_process, _client_train_process, _client_multiple_loaders_process) and 2 args dataclasses (ClientProcessArgs, ClientTrainProcessArgs) into a single _client_compute_process function with a compute_target callable on a unified ClientProcessArgs
  • Extracted _launch_graph_store_test() helper on the test class, consolidating ~40 lines of duplicated process-launching boilerplate (env mocking, process spawning, assertion) from each of the 4 test methods

Where is the documentation for this feature?: N/A

Did you add automated tests or write a test plan?

Updated Changelog.md? NO

Ready for code review?: NO

@kmontemayor2-sc
Copy link
Collaborator Author

/all_test

@github-actions
Copy link
Contributor

github-actions bot commented Mar 16, 2026

GiGL Automation

@ 20:16:51UTC : 🔄 Lint Test started.

@ 20:24:16UTC : ✅ Workflow completed successfully.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 16, 2026

GiGL Automation

@ 20:16:51UTC : 🔄 E2E Test started.

@ 21:43:13UTC : ✅ Workflow completed successfully.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 16, 2026

GiGL Automation

@ 20:16:51UTC : 🔄 Python Unit Test started.

@ 21:31:11UTC : ✅ Workflow completed successfully.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 16, 2026

GiGL Automation

@ 20:16:54UTC : 🔄 Integration Test started.

@ 21:45:19UTC : ✅ Workflow completed successfully.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 16, 2026

GiGL Automation

@ 20:16:54UTC : 🔄 Scala Unit Test started.

@ 20:26:18UTC : ✅ Workflow completed successfully.

Copy link
Collaborator

@mkolodner-sc mkolodner-sc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Kyle! Left a few quick question.

Copy link
Collaborator

@mkolodner-sc mkolodner-sc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Kyle!

@kmontemayor2-sc kmontemayor2-sc marked this pull request as ready for review March 19, 2026 23:15
@kmontemayor2-sc kmontemayor2-sc added this pull request to the merge queue Mar 23, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 23, 2026
@kmontemayor2-sc kmontemayor2-sc added this pull request to the merge queue Mar 23, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Mar 23, 2026
@kmontemayor2-sc kmontemayor2-sc added this pull request to the merge queue Mar 23, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 24, 2026
@kmontemayor2-sc kmontemayor2-sc added this pull request to the merge queue Mar 24, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 24, 2026
@kmontemayor2-sc kmontemayor2-sc added this pull request to the merge queue Mar 24, 2026
Merged via the queue into main with commit 5cfc25d Mar 24, 2026
6 checks passed
@kmontemayor2-sc kmontemayor2-sc deleted the kmonte/revamp-gs-integration branch March 24, 2026 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants