Open
Conversation
svij-sc
requested review from
kmontemayor2-sc,
mkolodner-sc,
nshah-sc,
xgao4-sc,
yliu2-sc and
zfan3-sc
as code owners
|
|
||
| class BqUtils: | ||
| def __init__(self, project: Optional[str] = None) -> None: | ||
| def __init__(self, project: Optional[str] = None, labels: dict[str, str] = {}) -> None: |
Collaborator
There was a problem hiding this comment.
nit. labels: Optional[dict[str, str]] = {} since the default variable is mutable.
kmontemayor2-sc
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now you have to pass in
labelsevery time you "run a query".This makes the code much more verbose than it needs to be and for you to pas around the
labelseverywhere.Added ability to just initialize BqUtils with labels and respective tests.