Merged
Conversation
…dling When edge_dir="in", DistNodeAnchorLinkSplitter reverses the supervision edge type, so test_dataset must store label edges under the reversed key and flip the edge index accordingly.
mkolodner-sc
requested review from
kmontemayor2-sc,
nshah-sc,
svij-sc,
xgao4-sc,
yliu2-sc and
zfan3-sc
as code owners
Collaborator
Author
|
/unit_test |
Collaborator
Author
|
/e2e_test |
Contributor
GiGL Automation@ 01:10:11UTC : 🔄 @ 02:30:54UTC : ✅ Workflow completed successfully. |
Contributor
GiGL Automation@ 01:10:12UTC : 🔄 @ 01:18:16UTC : ✅ Workflow completed successfully. |
Contributor
GiGL Automation@ 01:10:16UTC : 🔄 @ 02:28:54UTC : ✅ Workflow completed successfully. |
Collaborator
kmontemayor2-sc
left a comment
kmontemayor2-sc
left a comment
There was a problem hiding this comment.
Should we also add a test for the PPR sampler with this?
Collaborator
Author
@kmontemayor2-sc the PPR sampler branch already uses this change -- I split off this from that PR to be able to address this comment. |
kmontemayor2-sc
approved these changes
Mar 20, 2026
yliu2-sc
approved these changes
Mar 20, 2026
mkolodner-sc
deleted the
mkolodner-sc/fix_test_dataset_edge_dir_handling
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope of work done
When edge_dir="in", DistNodeAnchorLinkSplitter reverses the supervision edge type, so test_dataset must store label edges under the reversed key and flip the edge index accordingly.
Where is the documentation for this feature?: N/A
Did you add automated tests or write a test plan?
Updated Changelog.md? NO
Ready for code review?: NO