JS-1108 Fix false positives in S7739 for custom Promise/thenable implementations

[ss-vibe-bot]

Summary

Fixes false positives in rule S7739 (no-thenable) that were incorrectly flagging legitimate Promise and thenable implementations. The rule now recognizes intentional thenable patterns used in Promise polyfills, Deferred patterns, and objects made awaitable for Promise interoperability.

Key Changes

• RHS delegation patterns: Recognize obj.then = promise.then and obj.then = promise.then.bind(promise) patterns used in ant-design, vuetify, and jQuery
• Arrow function delegation: Handle result.then = (args) => promise.then(args) patterns used in ant-design's message components
• Promise/Deferred class context: Allow then methods defined in functions/classes named "Promise" or "Deferred" (polyfill and jQuery patterns)
• Prototype extension: Allow X.prototype.then assignments (React Promise pattern)
• Sibling thenable methods: Recognize objects with both then and catch/finally methods as complete thenable implementations
• Code quality: Applied optional chaining to fix S6582 code smell

Testing

• Added failing tests covering all the false positive patterns
• Updated expected ruling files (ruling tests pass)

Relates to JS-1108

[github-actions]

Ruling Report

Code no longer flagged (8 issues)

S7739

ag-grid/src/ts/misc/simpleHttpRequest.ts:26

    24 |     private thenFunc: (result: any)=>void;
    25 | 
>   26 |     public then(func: (result: any)=>void) {
    27 |         this.thenFunc = func;
    28 |     }

angular.js/src/ng/animateRunner.js:128

   126 |       },
   127 | 
>  128 |       then: function(resolveHandler, rejectHandler) {
   129 |         return this.getPromise().then(resolveHandler, rejectHandler);
   130 |       },

angular.js/src/ng/q.js:320

   318 | 
   319 |   extend(Promise.prototype, {
>  320 |     then: function(onFulfilled, onRejected, progressBack) {
   321 |       if (isUndefined(onFulfilled) && isUndefined(onRejected) && isUndefined(progressBack)) {
   322 |         return this;

ant-design/components/message/hooks/useMessage.tsx:65

    63 |         }
    64 |       };
>   65 |       result.then = (filled: ThenableArgument, rejected: ThenableArgument) =>
    66 |         closePromise.then(filled, rejected);
    67 |       result.promise = closePromise;

ant-design/components/message/index.tsx:199

   197 |     }
   198 |   };
>  199 |   result.then = (filled: ThenableArgument, rejected: ThenableArgument) =>
   200 |     closePromise.then(filled, rejected);
   201 |   result.promise = closePromise;

jquery/src/core/ready.js:55

    53 | } );
    54 | 
>   55 | jQuery.ready.then = readyList.then;
    56 | 
    57 | // The ready event handler and self cleanup method

jquery/src/deferred.js:102

   100 | 					} ).promise();
   101 | 				},
>  102 | 				then: function( onFulfilled, onRejected, onProgress ) {
   103 | 					var maxDepth = 0;
   104 | 					function resolve( depth, deferred, handler, special ) {

vuetify/packages/vuetify/src/components/VForm/VForm.tsx:37

    35 | 
    36 |       const ready = form.validate()
>   37 |       e.then = ready.then.bind(ready)
    38 |       e.catch = ready.catch.bind(ready)
    39 |       e.finally = ready.finally.bind(ready)

[sonarqube-next]

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
83.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

[ss-vibe-bot]

github-actions[bot] 2026-01-28T12:12:59Z addressed
These 8 issues are expected to no longer be flagged. All of them are intentional thenable implementations that were labeled as false positives:

File	Pattern	Reason
ag-grid simpleHttpRequest.ts:26	Custom Promise class	Class named Promise with then() method
angular.js animateRunner.js:128	Thenable delegating to Promise	then() delegates to getPromise().then()
angular.js q.js:320	Promise polyfill	Promise.prototype.then in $q implementation
ant-design useMessage.tsx:65	Arrow function delegation	result.then = (...) => closePromise.then(...)
ant-design index.tsx:199	Arrow function delegation	result.then = (...) => closePromise.then(...)
jquery ready.js:55	RHS delegation	jQuery.ready.then = readyList.then
jquery deferred.js:102	Sibling thenable methods	Has then, catch, and finally
vuetify VForm.tsx:37	Bind delegation	e.then = ready.then.bind(ready)

The fix correctly identifies these as legitimate Promise/thenable implementations per the approved approach.

[francois-mora-sonarsource]

LGTM