Skip to content

Fix dry runs#111

Open
MattiasBuelens wants to merge 4 commits intomainfrom
fix-dry-run
Open

Fix dry runs#111
MattiasBuelens wants to merge 4 commits intomainfrom
fix-dry-run

Conversation

@MattiasBuelens
Copy link
Contributor

The dryRun option in the Bump and release workflow wasn't very dry... First, the "bump and release" job would try to commit and push a bunch of things, and then the "cleanup" job would revert those changes.

Except, if "bump and release" is run as a dry run with the same version as the latest version, then the "clean up" job would remove the tag for that latest version! This happened in this run, which removed the 10.10.0 tag. We had to manually re-create that tag.

This reworks the workflow so dry runs don't push anything. Hence, they also don't need to be cleaned up, so we can't mess up the cleanup logic either. 😉

@MattiasBuelens
Copy link
Contributor Author

Tested in this run.

@therama
Copy link
Contributor

therama commented Feb 26, 2026

The reason why we push a tag is because the podspec file looks for the specific tag. By removing the push/undo-push steps you will break the validation process of the podspec which will look for that version tag. The reason why your dryRun succeeded in this run is because you are using a version who's tag already exists (10.10.0). Try running 10.11.0 and it should fail.
On a second note, this is a non-issue as long as we block dryRuns on versions that are already out. Normally you do dryRuns anyway with either future tags or tags with hyphenated postfixes indicating test/debug intentions.

@MattiasBuelens
Copy link
Contributor Author

MattiasBuelens commented Feb 26, 2026

@therama Do we not just do pod spec lint for dry runs? Does that need a tag on the remote?

I'll give it a go anyway. This is a run with the non-existent version 10.11.0-test.

@MattiasBuelens
Copy link
Contributor Author

MattiasBuelens commented Feb 26, 2026

Looks fine to me. 😁

@therama
Copy link
Contributor

therama commented Feb 27, 2026

It does look fine at first sight, but I delved into the logs and I see that it is fetching the incorrect versions:
Installing THEOplayer-Connector-Comscore (10.11.0) and the same for all the other connectors.
Source: https://productionresultssa2.blob.core.windows.net/actions-results/5c92b3af-077c-4617-ac36-41be52325a8e/workflow-job-run-d45b4759-4408-5c12-b29b-de2d5094473d/logs/job/job-logs.txt?rsct=text%2Fplain&se=2026-02-27T09%3A32%3A28Z&sig=exsLoJNDLxcmzrcrz5u%2BRYM9lbnWq2xMWHm1pslhi2Y%3D&ske=2026-02-27T10%3A38%3A31Z&skoid=ca7593d4-ee42-46cd-af88-8b886a2f84eb&sks=b&skt=2026-02-27T06%3A38%3A31Z&sktid=398a6654-997b-47e9-b12b-9515b896b4de&skv=2025-11-05&sp=r&spr=https&sr=b&st=2026-02-27T09%3A22%3A23Z&sv=2025-11-05

To clarify: the expected value should have been 10.11.0-test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants