-
Notifications
You must be signed in to change notification settings - Fork 165
feat(db): implement createEffect reactive effects API #1221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
samwillis
wants to merge
11
commits into
main
Choose a base branch
from
samwillis/create-effect
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
b493b9a
feat(db): implement createEffect and useLiveQueryEffect
samwillis 32e867d
feat(db): add source error handling, truncate and orderBy+limit tests
samwillis 828b8ab
ci: apply automated fixes
autofix-ci[bot] 8589afb
fix: resolve type error in select query test (non-null assertion for …
samwillis 1fc6ba2
fix(db): respect lazy source aliases in effect subscriptions
samwillis 864f1d5
feat(db): support lazy loading for orderBy+limit in effects
samwillis 6547bfb
refactor(db): extract shared helpers from effect and collection-subsc…
samwillis 3fb1ee6
ci: apply automated fixes
autofix-ci[bot] 5480240
fix(db): address PR review correctness issues in createEffect
samwillis 069d884
docs: add createEffect documentation to live queries guide
samwillis d2dbb82
chore: add changeset for createEffect
samwillis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| --- | ||
| '@tanstack/db': minor | ||
| '@tanstack/react-db': minor | ||
| --- | ||
|
|
||
| Add `createEffect` API for reactive delta-driven effects and `useLiveQueryEffect` React hook. | ||
|
|
||
| `createEffect` attaches handlers to a live query's delta stream — firing callbacks when rows enter, exit, or update within a query result — without materialising the full result set. Supports per-row and batch handlers, `skipInitial`, `orderBy` + `limit` (top-K window), joins, lazy loading, transaction coalescing, async disposal with `AbortSignal`, and `onSourceError` / `onError` callbacks. | ||
|
|
||
| `useLiveQueryEffect` is the React hook wrapper that manages the effect lifecycle (create on mount, dispose on unmount, recreate on dependency change). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current API of
createEffectonly allows you to register a single enter/update/exit handler. Sometimes we may want to register several ones. This would require storing the query in a variable and creating multiple effects. What if we could do that in a single effect definition?I also like that now you don't have to provide
onandhandlerprops but directly the handler:onEnter/onUpdate/onExit.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another design option for the API that is more consistent with the collections API:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like:
I think I change it to that.