Fix file rename in drawer views#4584
Open
geoffreysisco wants to merge 1 commit intoTeamAmaze:release/4.0from
Open
Fix file rename in drawer views#4584geoffreysisco wants to merge 1 commit intoTeamAmaze:release/4.0from
geoffreysisco wants to merge 1 commit intoTeamAmaze:release/4.0from
Conversation
Use file mode and parent directory from the selected item when invoking rename instead of fragment navigation state.
geoffreysisco
force-pushed
the
fix/failed-drawer-rename-file
branch
from
f8cd402 to
5c69d7f
Compare
VishnuSanal
added
the
PR-Awaiting-Initial-Review
VishnuSanal
added
PR-Awaiting-Final-Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use file mode and parent directory from the selected item when invoking rename instead of fragment navigation state.
Description
Rename from drawer views such as Audios and APKs failed with Operation Unsuccessful even though renaming the same files from a normal directory worked.
MainFragment.rename()was using fragment navigation state when invoking rename:mainFragmentViewModel.getOpenMode()mainFragmentViewModel.getCurrentPath()In drawer views, those values represent virtual drawer/category state rather than the selected file's actual filesystem context.
This change uses the selected item's:
f.getMode()new File(f.getPath()).getParent()Rename now resolves against the actual filesystem path.
Issue tracker
Fixes #4560
Automatic tests
Manual tests
Done
Device: Pixel 9 Pro emulator
OS: Android 16
Rooted: No
Version: 3.11.2
Build tasks success
Successfully running following tasks on local:
./gradlew assembleDebug./gradlew spotlessCheck