feat: allow disabling auto-advance of time in MockTimeSystem#971
Merged
feat: allow disabling auto-advance of time in MockTimeSystem#971
MockTimeSystem#971Conversation
There was a problem hiding this comment.
Pull request overview
Adds an opt-out for MockTimeSystem’s default behavior of auto-advancing simulated time when waiting via Task.Delay, Thread.Sleep, and PeriodicTimer.
Changes:
- Introduces
MockTimeSystemOptionsand new constructor overloads to allowDisableAutoAdvance(). - Threads the
autoAdvanceflag throughTaskMock,ThreadMock, andPeriodicTimermocks/factory. - Adds tests covering disabled auto-advance behavior for delay/sleep and periodic timers.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| Tests/Testably.Abstractions.Testing.Tests/MockTimeSystemTests.cs | Adds new tests verifying behavior when auto-advance is disabled. |
| Source/Testably.Abstractions.Testing/TimeSystem/ThreadMock.cs | Makes Thread.Sleep optionally stop advancing the mock time. |
| Source/Testably.Abstractions.Testing/TimeSystem/TaskMock.cs | Makes Task.Delay optionally stop advancing the mock time. |
| Source/Testably.Abstractions.Testing/TimeSystem/PeriodicTimerMock.cs | Implements non-auto-advance behavior by waiting for manual time changes. |
| Source/Testably.Abstractions.Testing/TimeSystem/PeriodicTimerFactoryMock.cs | Passes the autoAdvance setting into created periodic timers. |
| Source/Testably.Abstractions.Testing/MockTimeSystem.cs | Adds options-based constructors and wires the option into mocks/factories. |
Source/Testably.Abstractions.Testing/TimeSystem/PeriodicTimerMock.cs
Outdated
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an opt-out for
MockTimeSystem’s default behavior of auto-advancing simulated time when waiting viaTask.Delay,Thread.Sleep, andPeriodicTimer.Key Changes:
MockTimeSystemOptionsand new constructor overloads to allowDisableAutoAdvance().autoAdvanceflag throughTaskMock,ThreadMock, andPeriodicTimermocks/factory.PeriodicTimerinITimeSystem#960