FIX: OnScreenStick isolated dynamic origin hit detection. #2341
+2
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bug: https://issuetracker.unity3d.com/issues/inputsystems-onscreenstick-behaves-differently-when-using-exactpositionwithdynamicorigin-and-isolated-input-actions-enabled-slash-disabled
With isolated input actions enabled,
OnScreenStickonly accepted raycast hits on the stick’s root object. In dynamic origin mode the raycast actually hits the childDynamicOriginClickablegraphic which leads to the stick to ignore the press and never re-center.Fix is to treat raycast hits on any child of the stick as valid in isolated mode.
Testing status & QA
Manually verified with the repro steps provided in the case.
Overall Product Risks
Comments to reviewers
Checklist
Before review:
Changed,Fixed,Addedsections.Area_CanDoX,Area_CanDoX_EvenIfYIsTheCase,Area_WhenIDoX_AndYHappens_ThisIsTheResult.During merge:
NEW: ___.FIX: ___.DOCS: ___.CHANGE: ___.RELEASE: 1.1.0-preview.3.