Skip to content

Comments

deps: Update deps and move to yarn#72

Merged
thelukewalton merged 2 commits intomainfrom
deps
Feb 19, 2026
Merged

deps: Update deps and move to yarn#72
thelukewalton merged 2 commits intomainfrom
deps

Conversation

@thelukewalton
Copy link
Contributor

No description provided.

@DE7924
Copy link
Contributor

DE7924 commented Feb 19, 2026

PR Checks Complete

✅ Analysis

✅ Formatting

✅ Testing

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request migrates the project from npm to Yarn 4.12.0 as the package manager and updates several dependencies to their latest versions. The migration involves updating GitHub Actions workflows, adding Yarn configuration files, and regenerating the bundled distribution files.

Changes:

  • Migrated package manager from npm to Yarn 4.12.0 with configuration via .yarnrc.yml
  • Updated multiple dependencies including @playwright/test, @github/local-action, @types/node, @typescript-eslint/*, eslint, eslint-plugin-jest, and typedoc
  • Updated GitHub Actions workflows to use yarn install --immutable and yarn bundle instead of npm commands
  • Added CODEOWNERS file designating repository ownership
  • Regenerated bundled distribution files in dist/ reflecting dependency updates

Reviewed changes

Copilot reviewed 6 out of 13 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
package.json Removed redundant private field, updated dependency versions, added packageManager field for Yarn
.yarnrc.yml Added Yarn 4 configuration specifying node-modules linker and Yarn version
.github/workflows/ci.yml Updated to use Yarn commands and removed npm cache configuration
.github/workflows/check-dist.yml Updated to use Yarn commands and removed npm cache configuration
.github/CODEOWNERS Added new file designating repository code ownership
dist/* Regenerated bundled distribution files reflecting updated dependencies
custom-elements.json Updated manifest including additional build artifact entries
Comments suppressed due to low confidence (1)

custom-elements.json:374

  • The custom-elements.json file now includes entries for coverage and docs JavaScript files (lines 327-374). These generated/build artifacts should typically be excluded from custom element analysis. Consider adding these directories to the exclusion patterns in the custom-elements-manifest analyzer configuration to prevent them from being analyzed in future builds.
    {
      "kind": "javascript-module",
      "path": "src/scripts/analyze.ts",
      "declarations": [
        {
          "kind": "function",
          "name": "eslint",
          "return": {
            "type": {
              "text": "Promise<StepResponse>"
            }
          },
          "parameters": [
            {
              "name": "command",
              "type": {
                "text": "Command"
              },
              "description": "The command to run ESLint."
            }
          ],
          "description": "Executes an ESLint command and processes the output to generate an HTML table of linting issues."
        },
        {
          "kind": "function",
          "name": "litAnalyzer",
          "return": {
            "type": {
              "text": "Promise<StepResponse>"
            }
          },
          "parameters": [
            {
              "name": "command",
              "type": {
                "text": "Command"
              },
              "description": "The command to be executed and analyzed."
            }
          ],
          "description": "Analyzes the output of a given command using the lit-analyzer tool."
        },
        {
          "kind": "function",
          "name": "typeDoc",
          "return": {
            "type": {
              "text": "Promise<StepResponse>"

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@@ -0,0 +1 @@
* @thelukewalton No newline at end of file
Copy link

Copilot AI Feb 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CODEOWNERS file entry is missing the '@' prefix. GitHub CODEOWNERS requires usernames to be prefixed with '@'. This should be * @thelukewalton instead of * thelukewalton.

Copilot uses AI. Check for mistakes.
@@ -24,10 +24,9 @@ jobs:
uses: actions/setup-node@v6
with:
node-version-file: .node-version
Copy link

Copilot AI Feb 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The removal of cache: npm from the setup-node action is correct since the project is now using Yarn. However, to maintain caching benefits, consider adding cache: yarn to improve CI performance by caching Yarn dependencies.

Suggested change
node-version-file: .node-version
node-version-file: .node-version
cache: yarn

Copilot uses AI. Check for mistakes.
@thelukewalton thelukewalton merged commit 6ffc0dc into main Feb 19, 2026
2 checks passed
@thelukewalton thelukewalton deleted the deps branch February 19, 2026 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants