fix: restrict repay asset selection with zero-LTV collateral#2920
Open
vickyshaw29 wants to merge 1 commit intoaave:mainfrom
Open
fix: restrict repay asset selection with zero-LTV collateral#2920vickyshaw29 wants to merge 1 commit intoaave:mainfrom
vickyshaw29 wants to merge 1 commit intoaave:mainfrom
Conversation
|
@vickyshaw29 is attempting to deploy a commit to the Aave Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
General Changes
LtvValidationFailedcontract revert by blocking collateral-modifying repay paths at the UI levelCloses #2873
Developer Notes
RepayError.tsxhook follows the existingWithdrawError.tsxpatternRepayModal.tsxblocks the collateral repay tab (ParaSwap swap path) and shows a warning bannerRepayModalContent.tsxblocks the aToken repay path and disables the submit button viablockedpropRepayTypeSelector.tsxaddscollateralDisabledprop and a null guard on MUI ToggleButtonGroup onChangeuseZeroLTVBlockingWithdrawhook which already handles e-mode edge cases!== undefinedcheck to avoid JS falsy trapReviewer Checklist