Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #334 +/- ##
==========================================
- Coverage 90.83% 90.81% -0.02%
==========================================
Files 22 23 +1
Lines 3009 3024 +15
==========================================
+ Hits 2733 2746 +13
- Misses 276 278 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
khsrali
commented
Feb 19, 2026
|
|
||
| - name: Set up Python ${{ matrix.python-version }} | ||
| uses: actions/setup-python@v5 | ||
| - name: Set up uv |
Contributor
Author
There was a problem hiding this comment.
Uv installs python itself
khsrali
commented
Feb 19, 2026
| def reset_event_loop_policy() -> None: | ||
| """Reset the event loop policy to the default.""" | ||
| asyncio.set_event_loop_policy(None) | ||
| def get_or_create_event_loop() -> asyncio.AbstractEventLoop: |
Contributor
Author
There was a problem hiding this comment.
This file has the most important changes
Co-authored-by: Daniel Hollas <danekhollas@gmail.com>
khsrali
force-pushed
the
3.14
branch
2 times, most recently
from
422c1d5 to
0693a5f
Compare
This commit localizes all usecases of get_event_loop() in aiida-core in one single function get_or_create_event_loop. asyncio freqenctly is changing it's mind what should be deprecated and what should be back from deprecation and that's maintenance burden. By localizing all get/set logic in one place, we help ourselves to adopt in future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebase of #329
Free from
nest_asyncioPlus more changes
Update 1:
We should address #283 here
Update 2:
This PR should be break into at lest three commits:
Update 3: