Merged
Conversation
Reference issue: libsdl-org/SDL_image#537 Reference issue: libsdl-org/SDL_mixer#648 (cherry picked from commit bfab0a9)
- Remove duplicate 'dollar' symbol in the path - Use command 'file' to normalize file paths (cherry picked from commit 40b1eac)
(cherry picked from commit 035518d)
It looks like both macOS (15.1.1) and SDL are trying to talk to the controller at the same time, which can cause interleaved replies or even locking up the controller. Waiting a bit before talking to the controller seems to take care of this. (cherry picked from commit 45b01d1)
Shifting a signed int left by 31 is UB. (cherry picked from commit 15fd3fc)
This reverts commit 5925c27. Fixes libsdl-org#12807 (cherry picked from commit 5b95114)
Unregistering the input report callback marks the device as disconnected, so IOHIDDeviceClose() would never be called if the device wasn't already disconnected when hid_close() was called. Fixes libsdl-org#12255 (cherry picked from commit 2442c85)
This fixes undefined behavior resulting from adding offsets to nullptr. (cherry picked from commit a220e7c)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.