fix SDL_config.h errors on older glibc#28
Merged
jayschwa merged 3 commits intoallyourcodebase:mainfrom Jul 18, 2025
Merged
Conversation
glibc 2.37 and earlier does not support wcslcpy, wcslcat, strlcpy, and strlcat. Without implementing a more sophisticated detection, it is simpler to enable SDL's fallback functions for these often missing routines. example of affected systems: Linux Mint 21.3 and earlier Debian 12 (bookworm) and earlier Ubuntu 22.10 (kinetic) and earlier Fedora 37 and earlier Zorin 17.3 and earlier Also, updates README.md with some basic instructions.
jayschwa
requested changes
Jul 18, 2025
jayschwa
left a comment
jayschwa
left a comment
There was a problem hiding this comment.
Thanks for bringing this up. Let me know if my proposed changes will work for you. I don't have an easy way to test on old glibc at the moment.
Co-authored-by: Jay Petacat <github.com@jayschwa.net>
Co-authored-by: Jay Petacat <github.com@jayschwa.net>
Author
This works for me. |
jayschwa
approved these changes
Jul 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
glibc 2.37 and earlier does not support wcslcpy, wcslcat, strlcpy, and strlcat.
Without implementing a more sophisticated detection, it is simpler to enable SDL's fallback functions for these often missing routines.
example of affected systems:
Linux Mint 21.3 and earlier
Debian 12 (bookworm) and earlier
Ubuntu 22.10 (kinetic) and earlier
Fedora 37 and earlier
Zorin 17.3 and earlier
Also, updates README.md with some basic instructions.