This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(panel): allow transform to be animated on an offset panel#11389
Closed
Splaktar wants to merge 1 commit intoangular:panel-offset-animationfrom
Closed
fix(panel): allow transform to be animated on an offset panel#11389Splaktar wants to merge 1 commit intoangular:panel-offset-animationfrom
Splaktar wants to merge 1 commit intoangular:panel-offset-animationfrom
Conversation
Previously, if a panel had a position with an offset (e.g. `$mdPanel.newPanelPosition().center()`), the positioning would break any `transform` animations on the panel. This was due to the fact that `mdPanel` uses inline `transform` styles to do the offsetting. These changes introduce a wrapper around the panel (`.md-panel-inner-wrapper`), which will handle all of the positioning, allowing for any animations to be applied to the `.md-panel` itself. Relates to angular#9641. Fixes angular#9905.
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, if a panel had a position with an offset (e.g.
$mdPanel.newPanelPosition().center()), the positioning would break anytransformanimations on the panel. This was due to the fact thatmdPaneluses inlinetransformstyles to do the offsetting. These changes introduce a wrapper around the panel (.md-panel-inner-wrapper), which will handle all of the positioning, allowing for any animations to be applied to the.md-panelitself.Relates to #9641.
Fixes #9905.
PR Checklist
Please check that your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number:
What is the new behavior?
Does this PR introduce a breaking change?
Other information