fix(types): plugin trigger types are now correct and safe #11567
+37
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-correct-and-safe
Contributor
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
eXamadeus
commented
Feb 1, 2026
Contributor
Author
There was a problem hiding this comment.
The changes in here are technically all bug fixes. If they break downstream code, it's actually just catching bugs for them.
It's the unfortunate side effect of correcting misleading types.
eXamadeus
added a commit
to eXamadeus/opencode
that referenced
this pull request
Feb 1, 2026
…at more correctly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #7147
Related to #8380 (@aryasaatvik helped uncover the issue that led to a split)
This PR fixes a long standing issue with the plugin trigger types not being aligned. They are now FULLY correct and resilient to future divergence.
How did you verify your code works?
Typescript, baby!
Current State
Here's a great example of how this is currently broken, mess up a plugin hook type and see nothing happen:
After This PR
Everything is happy with the correct plugin trigger types!
And if we break them, incorrect types will propagate errors as the good Anders Hejlsberg intended!