feat(rust/driver_manager): make some functions and modules pub instead of pub(crate)#4052
Merged
zeroshade merged 2 commits intoapache:mainfrom Mar 9, 2026
Merged
Conversation
… APIs pub instead of pub(crate)
Contributor
|
The CI failure is unrelated to this change (see #4055). |
lidavidm
approved these changes
Mar 8, 2026
Contributor
Yes. I made then |
felipecrv
reviewed
Mar 9, 2026
| .join("etc") | ||
| .join("adbc") | ||
| .join("drivers"), | ||
| .join("profiles"), |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To facilitate more reuse of the functions for locating drivers, searching for manifests, and loading drivers directly, it makes sense to make some of the functionality directly public instead of being only
pub(crate). This will allow consumers to have more reuse of the components in the driver_manager (which I believe was the intent of the previous refactor in the first place).This includes
SearchHit,process_profile_value,DriverLibraryand some of the searching/loading methods ofDriverLibrary.