[bench] Replace pure-Rust snap with C++ snappy library for parquet (de)compression#9528
Draft
Dandandan wants to merge 3 commits intoapache:mainfrom
Draft
[bench] Replace pure-Rust snap with C++ snappy library for parquet (de)compression#9528Dandandan wants to merge 3 commits intoapache:mainfrom
Dandandan wants to merge 3 commits intoapache:mainfrom
Conversation
Use snappy_src (C++ snappy bindings) for raw snappy compress/decompress instead of the pure-Rust snap crate, while keeping snap as a dependency for CLI framed format support. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Author
|
run benchmark arrow_reader_clickbench |
|
🤖 |
Dandandan
changed the title
|
Benchmark script failed with exit code 101. Last 10 lines of output: Click to expand |
Dandandan
changed the title
Install g++ in CI setup-builder to provide libstdc++ needed by snappy_src. Move snappy_src to non-wasm32 target dependency and add pure-Rust snap fallback for wasm32 targets. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Author
|
run benchmark arrow_reader_clickbench |
|
🤖 |
|
Benchmark script failed with exit code 101. Last 10 lines of output: Click to expand |
Contributor
Author
|
run benchmark arrow_reader_clickbench CXXSTDLIB=c++ |
|
🤖 Hi @Dandandan, thanks for the request (#9528 (comment)).
Please choose one or more of these with You can also set environment variables on subsequent lines: Unsupported benchmarks: CXXSTDLIB=c++. |
Contributor
Author
|
run benchmark arrow_reader_clickbench |
|
🤖 |
|
Benchmark script failed with exit code 101. Last 10 lines of output: Click to expand |
15 tasks
Contributor
Author
|
run benchmark arrow_reader_clickbench |
|
🤖 |
|
Benchmark script failed with exit code 101. Last 10 lines of output: Click to expand |
Contributor
|
I will install libstdc++ on the runner |
Contributor
|
run benchmark arrow_reader_clickbench |
|
🤖 |
|
Benchmark script failed with exit code 101. Last 10 lines of output: Click to expand |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#9530
Use snappy_src (C++ snappy bindings) for raw snappy compress/decompress instead of the pure-Rust snap crate, while keeping snap as a dependency for CLI framed format support.
Getting some good perf numbers here.
Which issue does this PR close?
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?