[CALCITE-7360] The meaning of negation for unsigned numbers is not defined#4747
Open
mihaibudiu wants to merge 1 commit intoapache:mainfrom
Open
[CALCITE-7360] The meaning of negation for unsigned numbers is not defined#4747mihaibudiu wants to merge 1 commit intoapache:mainfrom
mihaibudiu wants to merge 1 commit intoapache:mainfrom
Conversation
|
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 90 days if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@calcite.apache.org list. Thank you for your contributions. |
Contributor
Author
|
I plan to update this PR |
…fined Signed-off-by: Mihai Budiu <mbudiu@feldera.com>
mihaibudiu
force-pushed
the
issue7360
branch
from
f0da079 to
9398704
Compare
|
Contributor
Author
|
This PR makes it illegal to use - on an unsigned value. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maybe I should change the title of the issue to "Make negation of UNSIGNED values illegal"
But no one replied to the JIRA issue, so here is a proposal for an implementation which does exactly that.