CAMEL-22980 - fix "specify custom port" in infra for Zookeeper

[apupier]

Description

Target

• I checked that the commit is targeting the correct branch (Camel 4 uses the main branch)

Tracking

• If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

• I checked that each commit in the pull request has a meaningful subject line and body.

• I have run mvn clean install -DskipTests locally from root folder and I have committed all auto-generated changes.

[github-actions]

🌟 Thank you for your contribution to the Apache Camel project! 🌟

🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

• First-time contributors require MANUAL approval for the GitHub Actions to run

• You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot.

• You can label PRs using build-all, build-dependents, skip-tests and test-dependents to fine-tune the checks executed by this PR.

• Build and test logs are available in the Summary page. Only Apache Camel committers have access to the summary.

• ⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

[Croway]

The custom port is needed by the camel infra command, what is the failure?

[Croway]

are the changes in ZooKeeperLocalContainerInfraService really needed?

aren't the ones in ZooKeeperContainer enough?

[apupier]

I don't know. My goal was to get back to a more stable main branch as soon as possible. So found the commit introducing the issue and tried to revert. We can adjust the previous work later on so that the main branch (and all other developments) is not impacted

[Croway]

ok, the changes to ZooKeeperContainer are ok, but the changes to ZooKeeperLocalContainerInfraService should be reverted, and, in order to support both camel test, and camel infra run with custom or default port scenarios, the following diff can be applied.

out.txt

[apupier]

what is the failure?

#21387 (comment)

[�[1;31mERROR�[m] �[1;31mFailures: �[m
[�[1;31mERROR�[m] �[1;31m  GroupIT.testJoinAfterConnect:216 expected: <true> but was: <false>�[m
[�[1;31mERROR�[m] �[1;31m  GroupIT.testJoinBeforeConnect:267 expected: <true> but was: <false>�[m
[�[1;31mERROR�[m] �[1;31m  GroupIT.testRejoinAfterDisconnect:306 expected: <true> but was: <false>�[m
[�[1;31mERROR�[m] �[1;31mErrors: �[m
[�[1;31mERROR�[m] �[1;31m  GroupIT.testAddFieldIgnoredOnParse:404 » ConnectionLoss KeeperErrorCode = ConnectionLoss for /singletons/test1770736846801�[m
[�[1;31mERROR�[m] �[1;31m  GroupIT.testGroupClose:358 » ConnectionLoss KeeperErrorCode = ConnectionLoss for /singletons/test1770736783644�[m
[�[1;31mERROR�[m] �[1;31m  GroupIT.testOrder:165 » ConditionTimeout Condition with alias 'Await for registration, the group must have an id' didn't complete within 1 minutes because condition with Lambda expression in org.apache.camel.component.zookeepermaster.group.GroupIT was not fulfilled.�[m

[apupier]

failing check is unrelated to this PR. i tis due to a regression on main branch, see this PR #21402 to revert this regression

[Croway]

@apupier In the diff there is a change to ZooKeeperLocalContainerInfraService

-                ? ZooKeeperContainer.CLIENT_PORT
+                ? ContainerEnvironmentUtil.getConfiguredPort(ZooKeeperContainer.CLIENT_PORT)

could you apply this change too?

[davsclaus]

Ah can we get the last bit attempted, and then also rebase on main