OSPF: adding dynamically routing capability to VPC by agneya2001 · Pull Request #1371 · apache/cloudstack

agneya2001 · 2016-01-27T12:07:01Z

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

    . Added zone level quagga/ospf config API and UI as addtional tab on zone
    . Added service offering with ospf
    . Added service offering for the tier guest network for VPC
    . Modified system vm template so that quagga is pre-installed
    . Added various configuration files that are required by Quagga
    . Added marvin tests for new APIs and unit test
    . Send quagga config from the server if VPC and tier are dynamically
    routed
    . Configure quagga when a VM of the tier is created/destroyed
    . Added necessary scritps on the vpc router to enable and configure
    quagga and iptable rules
    . Multiple Cidr management and netmask based cidr allocation
    . Added unit tests for cidr management
    . New dialog for create dynamic VPC and netmask as a field
    . Marvin tests to test dynmaic vpc service offering

remibergsma · 2016-02-04T09:22:37Z

setup/db/db/schema-471to480.sql

 ALTER TABLE `cloud`.`template_store_ref` MODIFY COLUMN `url` varchar(2048);
 ALTER TABLE `cloud`.`volume_store_ref` MODIFY COLUMN `url` varchar(2048);
 ALTER TABLE `cloud`.`volume_store_ref` MODIFY COLUMN `download_url` varchar(2048);
+


Please use schema-481to490.sql instead as 4.8.0 is already released.

@remibergsma thank you, will adjust the versions

agneya2001 · 2016-03-17T11:19:08Z

Marvin test log for testing ospf:

nosetests --with-xunit --xunit-file=/tmp/simulator/smoke/test_quota.xml --with-marvin --marvin-config=/root/cloudstack_shapeblue/advanced.cfg /root/cloudstack_shapeblue/test/integration/component/test_ospf.py -s -a tags=advanced,required_hardware=false --zone=Bootcamp --hypervisor=xenserver

==== Marvin Init Started ====

=== Marvin Parse Config Successful ===

=== Marvin Setting TestData Successful===

==== Log Folder Path: /tmp//MarvinLogs//Mar_17_2016_15_54_43_FRA4VS. All logs will be available here ====

=== Marvin Init Logging Successful===

==== Marvin Init Successful ====
test_01_dynamic_routing_using_ospf (integration.component.test_ospf.TestCreateDynmaicServiceOffering)
Response quaggaEnabled: true
Response ospfSuperCIDR: 200.100.0.0/16
Response quaggaEnabled: true
Response ospfSuperCIDR: 200.100.0.0/16
Check if the VPC offering is created successfully?
VPC offering is created successfully - Cosmic VPC off-8V5DNP
VPC Offering id = 0976e8a3-87ec-4f47-854d-7fb6433a64a4
Check if the VPC network is created successfully?
VPC network created successfully - Batman VPC-U784HI
VPC batman_vpc id = db59e37c-bd73-4c7b-b9af-6de6f494b4b0
Check if the VPC network is created successfully?
VPC network created successfully - Superman VPC-9OWLC6
VPC superman_vpc id = ffcdfa4d-2af8-43db-b7df-f3abc3e6ce78
Dynamic Network offering id = ffd45aec-9917-471e-8e90-297584963618
Created a network ACL list acl
Added a network ACL 3546e9cc-570f-495a-9bf2-60e1e4b823f2 to ACL list acl
Added a network ACL 02a4dbb2-e29a-4653-9d06-868d0aa6406c to ACL list acl
Verifying list network response to check if network created?
Created batman_network_tier1 with ID: c2eb368f-330c-4e08-b36f-a431e369023f
Created a network ACL list acl
Added a network ACL 48042210-7e6c-4001-97bb-625a36da9584 to ACL list acl
Added a network ACL a96782de-1d30-4650-b896-d27089ef9258 to ACL list acl
Verifying list network response to check if network created?
Created superman_network_tier1 with ID: e037f276-5527-43f5-8916-e97aaf0f4656
Using template 06415103-d802-44de-ba4c-82f1f465dda8
Using service offering 438477b3-f54d-4d59-a845-520ac91a874f
Deployed VM 75b13cfa-09d7-4836-a8ba-2b4aa33346f9 in network: c2eb368f-330c-4e08-b36f-a431e369023f
Deployed VM c5bbab5c-108b-4cfe-88d7-f87ae4e27bc3 in network: e037f276-5527-43f5-8916-e97aaf0f4656
Acquired public ip for batman vm 192.168.100.69
Static Nat enabled on ip 192.168.100.69
====Trying SSH Connection: Host:192.168.100.69 User:root Port:22 RetryCnt:60===
===SSH to Host 192.168.100.69 port : 22 SUCCESSFUL===
{Cmd: ping -c 1 200.100.5.101 via Host: 192.168.100.69} {returns: [u'PING 200.100.5.101 (200.100.5.101): 56 data bytes', u'64 bytes from 200.100.5.101: seq=0 ttl=62 time=2.347 ms', u'', u'--- 200.100.5.101 ping statistics ---', u'1 packets transmitted, 1 packets received, 0% packet loss', u'round-trip min/avg/max = 2.347/2.347/2.347 ms']}
[u'PING 200.100.5.101 (200.100.5.101): 56 data bytes', u'64 bytes from 200.100.5.101: seq=0 ttl=62 time=2.347 ms', u'', u'--- 200.100.5.101 ping statistics ---', u'1 packets transmitted, 1 packets received, 0% packet loss', u'round-trip min/avg/max = 2.347/2.347/2.347 ms']
Test successful clearing VMs
Test successful clearing VPC Tiers
Test successful clearing VPCs
=== TestName: test_01_dynamic_routing_using_ospf | Status : SUCCESS ===

===final results are now copied to: /tmp//MarvinLogs/test_ospf_DHP8KX===

agneya2001 · 2016-03-18T08:28:27Z

Documentation PR is here apache/cloudstack-docs-admin#36

terbolous · 2016-03-18T08:39:17Z

Would you mind running a broader test suite to verify that there are no regressions?

bvbharatk · 2016-03-18T17:11:37Z

ACS CI BVT Run

Sumarry:
Build Number 111
Hypervisor xenserver
NetworkType Advanced
Passed=105
Failed=13
Skipped=4

The follwing tests have known issues
test_vpc_remote_access_vpn
test_vpc_site2site_vpn
test_01_test_vm_volume_snapshot
test_02_vpc_privategw_static_routes
test_03_rvpc_privategw_static_routes
test_04_change_offering_small
ContextSuite context=TestNiciraContoller>:setup
test_01_primary_storage_iscsi
test02_internallb_haproxy_stats_on_all_interfaces
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80
ContextSuite context=TestDeployVM>:setup
test_04_extract_template
test_04_extract_Iso
test_07_list_default_iso

Link to logs Folder (search by build_no): https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0

Failed tests:

integration.smoke.test_guest_vlan_range.TestDedicateGuestVlanRange
- test_dedicateGuestVlanRange Failing since 2 runs

Skipped tests:
test_vm_nic_adapter_vmxnet3
test_deploy_vgpu_enabled_vm
test_06_copy_template
test_06_copy_iso

Passed test suits:
integration.smoke.test_deploy_vm_with_userdata.TestDeployVmWithUserData
integration.smoke.test_affinity_groups_projects.TestDeployVmWithAffinityGroup
integration.smoke.test_portable_publicip.TestPortablePublicIPAcquire
integration.smoke.test_over_provisioning.TestUpdateOverProvision
integration.smoke.test_global_settings.TestUpdateConfigWithScope
integration.smoke.test_scale_vm.TestScaleVm
integration.smoke.test_service_offerings.TestCreateServiceOffering
integration.smoke.test_loadbalance.TestLoadBalance
integration.smoke.test_routers.TestRouterServices
integration.smoke.test_reset_vm_on_reboot.TestResetVmOnReboot
integration.smoke.test_snapshots.TestSnapshotRootDisk
integration.smoke.test_deploy_vms_with_varied_deploymentplanners.TestDeployVmWithVariedPlanners
integration.smoke.test_network.TestDeleteAccount
integration.smoke.test_non_contigiousvlan.TestUpdatePhysicalNetwork
integration.smoke.test_deploy_vm_iso.TestDeployVMFromISO
integration.smoke.test_public_ip_range.TestDedicatePublicIPRange
integration.smoke.test_multipleips_per_nic.TestDeployVM
integration.smoke.test_regions.TestRegions
integration.smoke.test_affinity_groups.TestDeployVmWithAffinityGroup
integration.smoke.test_network_acl.TestNetworkACL
integration.smoke.test_pvlan.TestPVLAN
integration.smoke.test_volumes.TestCreateVolume
integration.smoke.test_ssvm.TestSSVMs
integration.smoke.test_nic.TestNic
integration.smoke.test_deploy_vm_root_resize.TestDeployVM
integration.smoke.test_resource_detail.TestResourceDetail
integration.smoke.test_secondary_storage.TestSecStorageServices
integration.smoke.test_vm_life_cycle.TestDeployVM
integration.smoke.test_disk_offerings.TestCreateDiskOffering

agneya2001 · 2016-03-21T05:32:39Z

@bvbharatk Thank you for running the marvin tests. Do you think any specific test that is failing on this branch ?

jburwell · 2016-03-24T16:36:41Z

api/src/com/cloud/network/Network.java

        Allocated("Indicates the network configuration is in allocated but not setup"), Setup("Indicates the network configuration is setup"), Implementing(
                "Indicates the network configuration is being implemented"), Implemented("Indicates the network configuration is in use"), Shutdown(
-                "Indicates the network configuration is being destroyed"), Destroy("Indicates that the network is destroyed");
+                        "Indicates the network configuration is being destroyed"), Destroy("Indicates that the network is destroyed");


This appears to be an unnecessary formatting change that actually misaligns the code.

jburwell · 2016-05-11T03:51:14Z

utils/src/main/java/com/cloud/utils/net/cidr/CIDRFactory.java

+            throw new BadCIDRException("Invalid mask length used: " + maskString);
+        }
+        return getCIDR(addr, mask);
+    }


Consider renaming getCIDR to create since the get verb is generally in Java for methods that access attributes.

jburwell · 2016-05-11T03:58:00Z

@abhinandanprateek Reading through the code, it seems like there could be benefit from the following value objects:

IpAddress interface whose implementations would wrap InetAddress to provide factory methods and operations specific to CloudStack orchestration
Netmask interface to encapsulate netmask-related operations for IPv4 and IPv6

Assuming that these new network primitives should orient us towards deprecating NetUtils, the new methods added to NetUtils for this enhancement should find a place in these new primitives.

swill · 2016-05-13T21:53:27Z

Please verify why the jobs are failing and re-push this PR to try to get it green. I need to verify the process to test new system templates and how to build and distribute new system templates. I have not tried to find the documentation on this, so if someone knows where to find it, I would accept a link. :)

DaanHoogland · 2020-03-06T14:45:40Z

@rhtyd @weizhouapache is this functionality worth keeping an eye on?

weizhouapache · 2020-03-06T15:03:59Z

wow, this is a quite big change.
I think it worths re-visiting. @DaanHoogland
not now, but 4.15 or 4.16.

yadvr · 2020-03-10T17:26:33Z

Hold-on, maybe useful in future when we want to allow route-able networks with bgp/ospf.

yadvr · 2021-09-08T05:02:31Z

Closing this old work, we'll revisit this in future.

abhinandanprateek force-pushed the master-quagga branch from 6d381c8 to 44de1ab Compare January 29, 2016 06:13

remibergsma reviewed Feb 4, 2016
View reviewed changes

abhinandanprateek force-pushed the master-quagga branch 3 times, most recently from 842e083 to 6ef6464 Compare February 8, 2016 09:20

abhinandanprateek force-pushed the master-quagga branch 4 times, most recently from 86e3885 to b54c0d5 Compare February 26, 2016 09:11

agneya2001 changed the title ~~OSPF: WIP: adding dynamically routing capability to VPC~~ OSPF: adding dynamically routing capability to VPC Feb 26, 2016

asfgit force-pushed the master branch from 7a9bfce to 359d20e Compare February 26, 2016 16:17

abhinandanprateek force-pushed the master-quagga branch 3 times, most recently from eee8f98 to 4f9c371 Compare March 14, 2016 10:23

abhinandanprateek force-pushed the master-quagga branch from 1970b6e to d7b3da7 Compare March 17, 2016 10:38

abhinandanprateek force-pushed the master-quagga branch from d7b3da7 to 71e5591 Compare March 18, 2016 11:29

abhinandanprateek force-pushed the master-quagga branch from 71e5591 to ce9ba84 Compare March 22, 2016 05:22

jburwell reviewed Mar 24, 2016
View reviewed changes

jburwell reviewed May 11, 2016
View reviewed changes

abhinandanprateek force-pushed the master-quagga branch 3 times, most recently from ef8ac31 to a2e9d26 Compare May 13, 2016 10:36

abhinandanprateek force-pushed the master-quagga branch 5 times, most recently from 95f2b5a to dbab29b Compare May 18, 2016 04:10

abhinandanprateek force-pushed the master-quagga branch from dbab29b to 1d2fd10 Compare February 6, 2017 05:09

kiwiflyer added type:enhancement component:virtual-router labels May 23, 2017

DaanHoogland added this to the 4.15.0.0 milestone Mar 6, 2020

DaanHoogland added the status:needs-work label Mar 9, 2020

yadvr modified the milestones: 4.15.0.0, 4.16.0.0 Jul 30, 2020

PaulAngus removed the type:enhancement label Nov 8, 2020

ACSGitBot added age:2years_plus labels Nov 8, 2020

DaanHoogland added type:new-feature and removed type:new_feature labels Nov 10, 2020

yadvr removed this from the 4.16.0.0 milestone Jun 17, 2021

yadvr closed this Sep 8, 2021

Conversation

agneya2001 commented Jan 27, 2016 • edited by PaulAngus Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Types of changes

Uh oh!

remibergsma Feb 4, 2016

Choose a reason for hiding this comment

Uh oh!

agneya2001 Feb 4, 2016

Choose a reason for hiding this comment

Uh oh!

agneya2001 commented Mar 17, 2016

Uh oh!

agneya2001 commented Mar 18, 2016

Uh oh!

terbolous commented Mar 18, 2016

Uh oh!

bvbharatk commented Mar 18, 2016

ACS CI BVT Run

Uh oh!

agneya2001 commented Mar 21, 2016

Uh oh!

jburwell Mar 24, 2016

Choose a reason for hiding this comment

Uh oh!

jburwell May 11, 2016

Choose a reason for hiding this comment

Uh oh!

jburwell commented May 11, 2016

Uh oh!

swill commented May 13, 2016

Uh oh!

DaanHoogland commented Mar 6, 2020

Uh oh!

weizhouapache commented Mar 6, 2020

Uh oh!

yadvr commented Mar 10, 2020

Uh oh!

yadvr commented Sep 8, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

agneya2001 commented Jan 27, 2016 •

edited by PaulAngus

Loading