[server] Fix TableChangeWatcher missing CreateTableEvent due to CuratorCache async getData race#2710
Open
swuferhong wants to merge 1 commit intoapache:mainfrom
Open
[server] Fix TableChangeWatcher missing CreateTableEvent due to CuratorCache async getData race#2710swuferhong wants to merge 1 commit intoapache:mainfrom
swuferhong wants to merge 1 commit intoapache:mainfrom
Conversation
…orCache async getData race
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #1018
When
MetadataManager.createTable()creates a table node empty (viacreatingParentsIfNeeded) and immediately calls
setDatawith real data,CuratorCache'sinternal asyncgetData()for theNodeCreatedevent mayread the post-setData state. This causes
NODE_CREATEDto carry fulldata (version>0) while the subsequent
NODE_CHANGEDis suppressed(same version already cached), resulting
in a lost
CreateTableEvent.Previously, processCreateTable was only called in the
NODE_CHANGEDbranch. This fix adds table path handling in the
NODE_CREATEDbranch:when
NODE_CREATEDfires with non-empty table data,processCreateTableis called as a fallback, ensuring
CreateTableEventis always producedregardless of whether
NODE_CHANGEDfires.This also fixes the case where
CuratorCacheinitial sync reportsexisting table nodes as
NODE_CREATEDwith full data.NODE_CREATEDbranchCuratorCacheRaceConditionTestto prove the race condition existstestTableCreationDetectedViaNodeCreatedEventto verify the fixBrief change log
Tests
API and Format
Documentation