GROOVY-6526: annotations: compute allowed targets lazily#2388
Open
eric-milles wants to merge 3 commits intomasterfrom
Open
GROOVY-6526: annotations: compute allowed targets lazily#2388eric-milles wants to merge 3 commits intomasterfrom
eric-milles wants to merge 3 commits intomasterfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2388 +/- ##
==================================================
- Coverage 66.7571% 66.7537% -0.0034%
- Complexity 29856 29866 +10
==================================================
Files 1382 1382
Lines 116130 116097 -33
Branches 20471 20469 -2
==================================================
- Hits 77525 77499 -26
+ Misses 32275 32269 -6
+ Partials 6330 6329 -1
🚀 New features to boost your workflow:
|
f8071cb to
7f34842
Compare
7f34842 to
c07e93d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move target checking from vmplugin to ast node. Only compute once per annotation type.
If this is okay, retention policy will follow.