Skip to content

GROOVY-6526: annotations: compute allowed targets lazily#2388

Open
eric-milles wants to merge 3 commits intomasterfrom
GROOVY-6526
Open

GROOVY-6526: annotations: compute allowed targets lazily#2388
eric-milles wants to merge 3 commits intomasterfrom
GROOVY-6526

Conversation

@eric-milles
Copy link
Member

Move target checking from vmplugin to ast node. Only compute once per annotation type.

If this is okay, retention policy will follow.

@codecov-commenter
Copy link

codecov-commenter commented Mar 1, 2026

Codecov Report

❌ Patch coverage is 77.41935% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.7537%. Comparing base (7d8349c) to head (c07e93d).

Files with missing lines Patch % Lines
...n/java/org/codehaus/groovy/ast/AnnotationNode.java 73.5849% 9 Missing and 5 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##               master      #2388        +/-   ##
==================================================
- Coverage     66.7571%   66.7537%   -0.0034%     
- Complexity      29856      29866        +10     
==================================================
  Files            1382       1382                
  Lines          116130     116097        -33     
  Branches        20471      20469         -2     
==================================================
- Hits            77525      77499        -26     
+ Misses          32275      32269         -6     
+ Partials         6330       6329         -1     
Files with missing lines Coverage Δ
...rg/codehaus/groovy/ast/decompiled/Annotations.java 89.8551% <ø> (-0.1449%) ⬇️
...org/codehaus/groovy/classgen/ExtendedVerifier.java 96.1373% <ø> (+4.2345%) ⬆️
...in/java/org/codehaus/groovy/vmplugin/VMPlugin.java 12.5000% <100.0000%> (+5.8333%) ⬆️
.../java/org/codehaus/groovy/vmplugin/v16/Java16.java 56.0000% <ø> (-3.2593%) ⬇️
...in/java/org/codehaus/groovy/vmplugin/v8/Java8.java 76.0135% <100.0000%> (-1.6991%) ⬇️
...in/java/org/codehaus/groovy/vmplugin/v9/Java9.java 59.7222% <ø> (-0.5517%) ⬇️
...tracts/ast/visitor/AnnotationProcessorVisitor.java 89.0909% <ø> (-0.1948%) ⬇️
...n/java/org/codehaus/groovy/ast/AnnotationNode.java 69.9029% <73.5849%> (-1.9281%) ⬇️

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@eric-milles eric-milles requested a review from paulk-asert March 5, 2026 15:37
@asf-gitbox-commits asf-gitbox-commits force-pushed the GROOVY-6526 branch 2 times, most recently from f8071cb to 7f34842 Compare March 5, 2026 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants