refactor: Optimize SnapshotUtil ancestor methods with early return#560
Open
WZhuo wants to merge 1 commit intoapache:mainfrom
Open
refactor: Optimize SnapshotUtil ancestor methods with early return#560WZhuo wants to merge 1 commit intoapache:mainfrom
WZhuo wants to merge 1 commit intoapache:mainfrom
Conversation
Contributor
WZhuo
commented
Feb 11, 2026
WZhuo
commented
- Optimize IsAncestorOf to return early instead of collecting all ancestors
- Optimize IsParentAncestorOf to return early when matching parent is found
- Add TableMetadata overloads for AncestorsOf, AncestorsBetween, OldestAncestorOf
- Add IsParentAncestorOf overload with custom lookup function
- Optimize IsAncestorOf to return early instead of collecting all ancestors - Optimize IsParentAncestorOf to return early when matching parent is found - Add TableMetadata overloads for AncestorsOf, AncestorsBetween, OldestAncestorOf - Add IsParentAncestorOf overload with custom lookup function
zhjwpku
approved these changes
Feb 11, 2026
Collaborator
zhjwpku
left a comment
zhjwpku
left a comment
There was a problem hiding this comment.
An early return should improve performance when there is a large snapshot history, so +1 from me. Thanks for working on this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.