[IOTDB-17108] Support inclusive end time syntax [start, end] in GROUP BY clause#17180
Open
PDGGK wants to merge 1 commit intoapache:masterfrom
Open
[IOTDB-17108] Support inclusive end time syntax [start, end] in GROUP BY clause#17180PDGGK wants to merge 1 commit intoapache:masterfrom
PDGGK wants to merge 1 commit intoapache:masterfrom
Conversation
… BY clause This commit adds support for double-closed interval [start, end] in GROUP BY time clause, complementing the existing half-open interval [start, end). Changes: - Add grammar rule for [start, end] syntax in IoTDBSqlParser.g4 - Add rightClosed field to GroupByTimeComponent and GroupByTimeParameter - Implement getFinalTimeRange() override in iterator classes to handle inclusive end time by preserving the right boundary - Update TimeRangeIteratorFactory signature (9 args) with rightClosed param - Update ExpressionFactory to normalize [start, end] to [start, end+1) - Fix test signatures in TimeRangeIteratorTest for new factory signature Usage: SELECT count(s1) FROM root.test GROUP BY ([0, 100], 10ms) -- includes 100 Fixes apache#17108
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for double-closed interval
[start, end]in GROUP BY time clause, complementing the existing half-open interval[start, end).New Syntax
Changes
IoTDBSqlParser.g4]right bracketGroupByTimeComponent.javarightClosedfieldGroupByTimeParameter.javarightClosedASTVisitor.javaAggregationUtil.javarightClosedto factoryTimeRangeIteratorFactory.javaAggrWindowIterator.javagetFinalTimeRange()for inclusive endPreAggrWindowIterator.javagetFinalTimeRange()for inclusive endPreAggrWindowWithNaturalMonthIterator.javaGroupByTimeExpression.javaExpressionFactory.java[start, end]to[start, end+1)TimeRangeIteratorTest.javaTest Plan
TimeRangeIteratorTest- 4 tests)mvn spotless:check)Compatibility
This is a backward-compatible change. The existing
[start, end)syntax continues to work as before. The new[start, end]syntax is opt-in.Fixes #17108