Fix end of files; files should end with one newline#914
Closed
jbampton wants to merge 1 commit intoapache:mainfrom
Closed
Fix end of files; files should end with one newline#914jbampton wants to merge 1 commit intoapache:mainfrom
jbampton wants to merge 1 commit intoapache:mainfrom
Conversation
Contributor
|
@jbampton did you test the result? |
Member
|
and why is this required? and TBH i dont like to accept such mass PRs |
Member
Author
It is standard practice to end files with a newline. We can add a pre-commit hook that enforces this rule just like other top ASF projects. So I have been waiting 2 months for #917 to be reviewed. @tandraschko that is fine. I will close this PR and move on to another project. Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.