[fix] off-by-one malloc #458
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
Fixes a potential off-by-one buffer overflow in the native token supplier implementation used by token-based authentication, addressing a crash observed during auth challenge handling.
Changes:
- Allocate one extra byte for the terminating
\0before copying the token viastrcpy.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still seeing ocassional issues even after #412
During further investigation of the Token Auth supplier crash when the runtime is handling AuthChallenges, we found a potential off-by-one buffer overflow in the token allocation code.
strcpycopies the terminating\0, but the buffer is allocated usingsize(), which does not include space for it, resulting in an off-by-one write.