RANGER-5505: update RangerEmbeddedAuthorizer to support caller provided audit handler#864
Open
mneethiraj wants to merge 2 commits intoapache:masterfrom
Open
RANGER-5505: update RangerEmbeddedAuthorizer to support caller provided audit handler#864mneethiraj wants to merge 2 commits intoapache:masterfrom
mneethiraj wants to merge 2 commits intoapache:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support in the embedded authorizer for caller-provided audit handlers so callers can control how audit events are handled/logged, and introduces a configurable appType used during audit initialization/agent identification.
Changes:
- Added
authorize()overloads onRangerEmbeddedAuthorizerthat accept a caller-providedRangerAuthzAuditHandler. - Introduced
ranger.authz.app.typeconfiguration and used it to initialize the audit provider / set audit agentId. - Refactored multi-authorize logic into a private helper method shared by both entry points.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| authz-embedded/src/main/java/org/apache/ranger/authz/embedded/RangerEmbeddedAuthorizer.java | Adds caller-provided audit handler overloads; changes audit initialization to use configured appType; refactors multi-authorize auditing path. |
| authz-embedded/src/main/java/org/apache/ranger/authz/embedded/RangerAuthzConfig.java | Adds ranger.authz.app.type property + accessor; renames init-services constant. |
| authz-embedded/src/main/java/org/apache/ranger/authz/embedded/RangerAuthzAuditHandler.java | Changes audit handler to accept an appType string and use it as the audit event agentId. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
authz-embedded/src/main/java/org/apache/ranger/authz/embedded/RangerEmbeddedAuthorizer.java
Show resolved
Hide resolved
authz-embedded/src/main/java/org/apache/ranger/authz/embedded/RangerEmbeddedAuthorizer.java
Show resolved
Hide resolved
authz-embedded/src/main/java/org/apache/ranger/authz/embedded/RangerAuthzConfig.java
Show resolved
Hide resolved
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
authz-embedded/src/main/java/org/apache/ranger/authz/embedded/RangerAuthzAuditHandler.java
Show resolved
Hide resolved
authz-embedded/src/main/java/org/apache/ranger/authz/embedded/RangerAuthzAuditHandler.java
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
RangerAuthzAuditHandlerinstances to handle generated audit logsHow was this patch tested?