Migrate SplitCore and SplitShard to Jax-rs#4179
Draft
epugh wants to merge 9 commits intoapache:mainfrom
Draft
Conversation
Co-authored-by: epugh <22395+epugh@users.noreply.github.com>
Co-authored-by: epugh <22395+epugh@users.noreply.github.com>
Co-authored-by: epugh <22395+epugh@users.noreply.github.com>
…client via getSolrClient() Co-authored-by: epugh <22395+epugh@users.noreply.github.com>
…sts after JAX-RS migration Co-authored-by: epugh <22395+epugh@users.noreply.github.com>
…cks after JAX-RS migration Co-authored-by: epugh <22395+epugh@users.noreply.github.com>
github-actions
bot
added
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestApiFramework.testFrameworkwas failing because it asserted the existence of a/commands/splitendpoint at/collections/{collection}/shardsin the old-styleApiBagregistry — butSplitShardAPIwas migrated to JAX-RS and removed fromCollectionsHandler.getApis(), so that path no longer resolves viaV2HttpCall.getApiInfo().Changes
TestApiFramework.java: Removed the obsolete block that looked up/collections/hello/shardsPOST and asserted/commands/splitin the spec. The remaining assertions against/collections/helloPOST (/commands/modify) and the_introspectpath are still valid and continue to exercise the V2 API framework lookup mechanics.