Fix log_retention test: use correct test run variable#12884
Merged
brbzull0 merged 1 commit intoapache:masterfrom Feb 13, 2026
Merged
Fix log_retention test: use correct test run variable#12884brbzull0 merged 1 commit intoapache:masterfrom
brbzull0 merged 1 commit intoapache:masterfrom
Conversation
Test 7 ('Get the log to rotate.') was calling MakeCurlCommandMulti on
test.tr (the test run from the TestLogRetention constructor) instead of
the newly created tr. This left the new test run with no process
defined, causing the test to fail with 'List came back empty.'
Contributor
Author
|
@bneradt: This seems to be ok now , not sure if we haven't detect the issue because of the initial skip, but anyways. Works for me now. |
bneradt
approved these changes
Feb 13, 2026
Contributor
Yep. This test is skipped in CI because it has timing issues. Thanks for the fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was failing on my box.
Test 7 ('Get the log to rotate.') was calling MakeCurlCommandMulti on test.tr (the test run from the TestLogRetention constructor) instead of the newly created tr. This left the new test run with no process defined, causing the test to fail with 'List came back empty.'