Stabilize post and slow_post autests under parallel runs#12886
Open
bryancall wants to merge 3 commits intoapache:masterfrom
Open
Stabilize post and slow_post autests under parallel runs#12886bryancall wants to merge 3 commits intoapache:masterfrom
bryancall wants to merge 3 commits intoapache:masterfrom
Conversation
Gate each check_threads invocation on ATS port readiness using When.PortOpen(ts.Variables.port) to avoid races where validation runs before traffic_server is ready.
Add explicit origin readiness checks in post-early-return and accept the current microserver exception variant in server_abort so these tests pass consistently on Fedora 43.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves determinism in the thread_config gold test by ensuring the thread-validation helper (check_threads.py) does not run until the corresponding ATS instance is actually accepting connections on its configured port, eliminating a startup-order race in parallel autest runs.
Changes:
- Add per-run readiness gating so each
check_threads.pyinvocation waits onWhen.PortOpen(ts.Variables.port)before proceeding. - Apply the same readiness condition consistently across all thread-configuration variants in the test.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bneradt
requested changes
Feb 13, 2026
Revert the thread_config PortOpen readiness change and keep ATS process startup gating on its existing fully-initialized readiness behavior. For post-early-return, move upstream readiness to server process Ready fields instead of passing ready via StartBefore calls.
bryancall
changed the title
bneradt
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
post-early-returnby assigning readiness oneach upstream process (
serverN.Ready = When.PortOpen(...))StartBefore(serverN)call sites simple and aligned with reviewerguidance
slow_post/server_abortstderr matcher to accept an additionalobserved exception signature from the intentionally misconfigured origin
Test plan
-j 16)post-early-returnslow_post/server_abortstill asserts expected origin abort behavior