Skip to content

Refactor branding preference fetching logic#406

Open
kavindadimuthu wants to merge 1 commit intoasgardeo:mainfrom
kavindadimuthu:fix/branding-issue
Open

Refactor branding preference fetching logic#406
kavindadimuthu wants to merge 1 commit intoasgardeo:mainfrom
kavindadimuthu:fix/branding-issue

Conversation

@kavindadimuthu
Copy link
Contributor

Purpose

This pull request updates the branding preferences logic in the SDK to ensure branding is only fetched and applied when explicitly enabled, rather than by default. The changes clarify the documentation and adjust the code to require inheritFromBranding to be set to true for branding to be fetched.

Branding preferences logic update:

  • Updated the documentation for the inheritFromBranding property in the ThemePreferences interface to clarify that branding is only fetched when explicitly enabled, and defaults to false.
  • Changed the branding fetch logic in AsgardeoProvider to only fetch branding when preferences.theme.inheritFromBranding is true, rather than when it is not false.
  • Updated the enabled prop for branding in AsgardeoProvider to require preferences.theme.inheritFromBranding to be true.

Related Issues

Related PRs

  • N/A

Checklist

  • Followed the CONTRIBUTING guidelines.
  • Manual test round performed and verified.
  • Documentation provided. (Add links if there are any)
  • Unit tests provided. (Add links if there are any)

Security checks

@asgardeo-github-bot
Copy link

⚠️ No Changeset found

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go.

If these changes should result in a version bump, you need to add a changeset.

Refer Release Documentation to learn how to add a changeset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Gracefully handle branding preferences API call error message in React SDK

2 participants