Do not call getattr with a constant value#381
Open
DimitriPapadopoulos wants to merge 1 commit intoastanin:masterfrom
Open
Do not call getattr with a constant value#381DimitriPapadopoulos wants to merge 1 commit intoastanin:masterfrom
getattr with a constant value#381DimitriPapadopoulos wants to merge 1 commit intoastanin:masterfrom
Conversation
It is not any safer than normal property access. It feels like the intent might have been `hasattr()` instead of `getattr()`, but the initial commit e2086c3 appears to : - assume any attribute `dtype` is of type `numpy.dtype`, - test whether `numpy.dtype.names` is a list of fields names or `None`. https://numpy.org/doc/stable/reference/generated/numpy.dtype.names.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is not any safer than normal property access.
It feels like the intent might have been
hasattr()instead ofgetattr(), but the initial commit e2086c3 appears to :dtypeis of typenumpy.dtype,numpy.dtype.namesis a list of fields names orNone.https://numpy.org/doc/stable/reference/generated/numpy.dtype.names.html
Requires #373.