Fix handling of training step dependencies to allow successful pipeline creation#5618
Merged
mollyheamazon merged 11 commits intoaws:masterfrom Mar 12, 2026
Merged
Fix handling of training step dependencies to allow successful pipeline creation#5618mollyheamazon merged 11 commits intoaws:masterfrom
mollyheamazon merged 11 commits intoaws:masterfrom
Conversation
Contributor
mollyheamazon
left a comment
There was a problem hiding this comment.
Please add unit test to your fix
2 tasks
mollyheamazon
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes: Fix handling of dependencies in
get_training_code_hashworkflow utility so that training steps without arequirementsparam specified will still create a pipeline.Originally,
dependenciesparam of functionget_training_code_hashassumed a list of strings. But for the training step, this is actually referring torequirementswhich can be a string, pipeline variable, or None - not a list. When this function is called, it tries to returnhash_files_or_dirs([source_dir] + dependencies)but throws a list concatenation error becausedependencieswill always be either a string, pipeline variable, or None.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.