Skip to content

Fix handling of training step dependencies to allow successful pipeline creation#5618

Merged
mollyheamazon merged 11 commits intoaws:masterfrom
bobbywlindsey:master
Mar 12, 2026
Merged

Fix handling of training step dependencies to allow successful pipeline creation#5618
mollyheamazon merged 11 commits intoaws:masterfrom
bobbywlindsey:master

Conversation

@bobbywlindsey
Copy link
Contributor

Issue #, if available:

Description of changes: Fix handling of dependencies in get_training_code_hash workflow utility so that training steps without a requirements param specified will still create a pipeline.

Originally, dependencies param of function get_training_code_hash assumed a list of strings. But for the training step, this is actually referring to requirements which can be a string, pipeline variable, or None - not a list. When this function is called, it tries to return hash_files_or_dirs([source_dir] + dependencies) but throws a list concatenation error because dependencies will always be either a string, pipeline variable, or None.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@bobbywlindsey bobbywlindsey changed the title Fix handling of dependencies to allow successful pipeline creation Fix handling of training step dependencies to allow successful pipeline creation Mar 10, 2026
Copy link
Contributor

@mollyheamazon mollyheamazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add unit test to your fix

@mollyheamazon mollyheamazon merged commit 238c019 into aws:master Mar 12, 2026
15 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants