fix(Scripts/StormPeaks): Rewrite Time-Lost Proto Drake

[Gultask]

Changes Proposed:

This PR proposes changes to:

• Core (units, players, creatures, game systems).
• Scripts (bosses, spell scripts, creature scripts).
• Database (SAI, creatures, etc).

Adds 4 different spawns and paths from sniffed data
Decreased chances of spawning as Time-Lost from 25% to 10% (provided in linked issue, from our data we've seen it 1 in 12 times)

AI-assisted Pull Requests

Important

While the use of AI tools when preparing pull requests is not prohibited, contributors must clearly disclose when such tools have been used and specify the model involved.

Contributors are also expected to fully understand the changes they are submitting and must be able to explain and justify those changes when requested by maintainers.

• AI tools (e.g. ChatGPT, Claude, or similar) were used entirely or partially in preparing this pull request. Please specify which tools were used, if any.

Initial cleanup of the creature script, but it doesn't know up-to-date code standards so I rewrote it anyways.

Issues Addressed:

• Closes [NPC] Time-Lost Proto Drake / Vyragosa - issues with spawn timer, spawn points, travel routes and movement speed chromiecraft/chromiecraft#8941

SOURCE:

The changes have been validated through:

• Live research (checked on live servers, e.g Classic WotLK, Retail, etc.)
• Sniffs (remember to share them with the open source community!)
• Video evidence, knowledge databases or other public sources (e.g forums, Wowhead, etc.)
• The changes promoted by this pull request come partially or entirely from another project (cherry-pick). Cherry-picks must be committed using the proper --author tag in order to be accepted, thus crediting the original authors, unless otherwise unable to be found

Tests Performed:

This PR has been:

• Tested in-game by the author.
• Tested in-game by other community members/someone else other than the author/has been live on production servers.
• This pull request requires further testing and may have edge cases to be tested.

How to Test the Changes:

• This pull request can be tested by following the reproduction steps provided in the linked issue
• This pull request requires further testing. Provide steps to test your changes. If it requires any specific setup e.g multiple players please specify it as well.

Known Issues and TODO List:

• [ ]
• [ ]

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

[Gultask]

Should we make the timers and chances worldserver conf values? We have manabonk in the config.

[Copilot]

Pull request overview

This PR rewrites the Time-Lost Proto Drake / Vyragosa behavior and associated world data to better match sniffed paths and spawn behavior in the Storm Peaks.

Changes:

• Refactors npc_time_lost_proto_drake from npc_escortAI + script_waypoint to a ScriptedAI using DB-driven waypoint paths and modern scheduling helpers.
• Adjusts creature_template and creature_model_info for Vyragosa and Time-Lost, and replaces old script waypoints with four sniff-based waypoint paths in waypoint_data.
• Rebuilds creature spawns, pools, and addons for Time-Lost/Vyragosa to support four separate path spawns at a reduced Time-Lost chance.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File	Description
src/server/scripts/Northrend/zone_storm_peaks.cpp	Updates Time-Lost Proto Drake AI to use ScriptedAI, randomizes entry between Time-Lost and Vyragosa, sets flying behavior, and adds new spell timer scheduling.
data/sql/updates/pending_db_world/rev_1769117901544014100.sql	Tweaks templates and model info, defines four new waypoint paths, recreates creature spawns and pool configuration, and wires up creature_addon path bindings.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[TheSCREWEDSoftware]

With this changes does they still choose a random waypoint to spawn?

[Gultask]

With this changes does they still choose a random waypoint to spawn?

No.
Well, yes?

Before it was a single path with 250 points. Now it has 4 different paths, chosen by the pooling system with equal chance to each path.
The paths are sniffed. Flying creatures usually send all points in the CreateObject packet, so we can extract in bulk. Take it from 12 different sniffs, and we got 4 different paths.
I also kept the old system with it being Invisible for a time, so it'll be at a random place in the waypoint by the time it appears.

[TheSCREWEDSoftware]

I don't know the blizz way, but I assume they tried to make it less predicable as possible? Any of sniffs does any of the dragons spawn in the same place or was always different places? asking because how bad does it sound to have it after picking up 1 of 4 possible routes, to pick a random waypoint within that route + the invisible peridioc (this in theorry should make the dragons fully impredicable

[Gultask]

I doubt I caught every consecutive spawn, but in some cases, I'd get the same path in two consecutive days.
And, as far as I know, while we get the entire path in a single packet, I don't know the actual spawn position as I never actually got to see them spawn.

If predictability is important then it's no worry as the range to turn visible is huge and they do continue pathing while invisible.

[ChromedByrd]

Videos With Blizz Like Spawn Information

Below are videos that look like there is proof for where these rare spawns are.

Video 1

loud warning
Bragging in General Chat About Spawn

Video 2

beautiful music warning
Dragons Are Made of Mountains

Video 3

Better Explanation With Some Fluff

Important Times in the video

https://www.youtube.com/watch?v=ZtIJ-Z7MK_0&t=32s
https://youtu.be/ZtIJ-Z7MK_0?t=206