fix(DB/game_event): implement 'Brewfest Building (Orgrimmar)' #24517
Conversation
There was a problem hiding this comment.
Pull request overview
This PR implements the "Brewfest Building (Orgrimmar)" event to complement the existing Ironforge version. The changes add gameobjects, setup crew NPCs, and temporarily despawn conflicting creatures in the Orgrimmar Brewfest area during the building phase of the event.
Changes:
- Created new game event 91 for "Brewfest Building (Orgrimmar)" tied to the Brewfest holiday
- Added 76 gameobject spawns (decorations, barrels, tents, etc.) for the Brewfest setup area
- Added 9 setup crew NPCs (creature ID 23504) with appropriate equipment, emotes, and auras
- Configured 21 existing creatures to despawn during the event to avoid conflicts with the setup area
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Benjamin Jackson <[email protected]>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| (12770, 0, 0, 0, 0, 233, 0, '43992'), | ||
| (12771, 0, 0, 0, 0, 432, 0, '43992'), | ||
| (12772, 0, 0, 0, 0, 233, 0, '43992'), | ||
| (12773, 0, 0, 0, 0, 432, 0, '43992'), |
There was a problem hiding this comment.
Add these back without the emote, cause I changed the default waypoint dump to UPDATE instead of INSERTing new creature_addon :P
3 participants
Changes Proposed:
This PR proposes changes to:
AI-assisted Pull Requests
Important
While the use of AI tools when preparing pull requests is not prohibited, contributors must clearly disclose when such tools have been used and specify the model involved.
Contributors are also expected to fully understand the changes they are submitting and must be able to explain and justify those changes when requested by maintainers.
Issues Addressed:
SOURCE:
The changes have been validated through:
Tests Performed:
This PR has been:
How to Test the Changes:
.event start 91.go c 12773Known Issues and TODO List:
How to Test AzerothCore PRs
When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].
You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:
http://www.azerothcore.org/wiki/How-to-test-a-PR
REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).
For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.