-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
fix(DB/game_event): Brewfest Building (Ironforge) #24527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix(DB/game_event): Brewfest Building (Ironforge) #24527
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds missing gameobjects for the Brewfest Building event in Ironforge (event ID 70). The changes are based on sniffed values from Wrath Classic and aim to address the incomplete setup mentioned in issue #17313.
Changes:
- Updates 10 existing gameobject spawns with corrected positions and rotations from sniffs
- Adds 60 new gameobject spawns for various Brewfest decorations and objects
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| -- TODO: guids 12821 and 12822 should have waypoints and SAI | ||
| (12821, 23504, 0, 1, 1, 0, -5169.5498046875, -561.426513671875, 397.289520263671875, 2.513752937316894531, 120, 0, 0, 0, 0, 0, "TODO: needs waypoints and SAI", 50664, 1, NULL), | ||
| (12822, 23504, 0, 1, 1, 0, -5172.8818359375, -622.4075927734375, 397.301177978515625, 3.694555997848510742, 120, 0, 0, 0, 0, 0, "TODO: needs waypoints and SAI", 50664, 1, NULL), |
Copilot
AI
Jan 28, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The TODO comments in the ScriptName field are non-standard. This field is meant for referencing actual script names, not documentation. Consider moving these TODO notes to separate SQL comments above the INSERT statement or tracking them in the PR description/issue tracker instead of in the database field.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's the wrong column >:(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-- Pathing for Entry: 23504
SET @NPC := 12828;
SET @PATH := @NPC * 10;
UPDATE `creature` SET `wander_distance`=0,`MovementType`=2 WHERE `guid`=@NPC;
UPDATE `creature_addon` SET `path_id` = @PATH WHERE `guid` = @NPC;
DELETE FROM `waypoint_data` WHERE `id`=@PATH;
INSERT INTO `waypoint_data` (`id`,`point`,`position_x`,`position_y`,`position_z`,`orientation`,`delay`,`move_type`,`action`,`action_chance`,`wpguid`) VALUES
(@PATH,1,-5221.1157,-478.54193,386.97256,NULL,0,0,0,100,25000),
(@PATH,2,-5210.8853,-465.23352,387.57217,NULL,0,0,0,100,25000),
(@PATH,3,-5216.8687,-472.79004,386.83,NULL,0,0,0,100,0);
-- .go xyz -5221.1157 -478.54193 386.97256There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know which ones are these 😭
-- Pathing for Entry: 23504
SET @NPC := XXXXXX;
SET @PATH := @NPC * 10;
UPDATE `creature` SET `wander_distance`=0,`MovementType`=2,`position_x`=-5179.5845,`position_y`=-554.1431,`position_z`=397.27936 WHERE `guid`=@NPC;
UPDATE `creature_addon` SET `path_id` = @PATH WHERE `guid` = @NPC;
DELETE FROM `waypoint_data` WHERE `id`=@PATH;
INSERT INTO `waypoint_data` (`id`,`point`,`position_x`,`position_y`,`position_z`,`orientation`,`delay`,`move_type`,`action`,`action_chance`,`wpguid`) VALUES
(@PATH,1,-5179.5845,-554.1431,397.27936,NULL,0,0,0,100,0),
(@PATH,2,-5179.5845,-554.1431,397.27936,1.186823844909667968,0,0,0,100,20000),
(@PATH,3,-5174.075,-559.6432,397.27936,NULL,0,0,0,100,0),
(@PATH,4,-5164.4526,-578.34515,397.30118,NULL,0,0,0,100,0),
(@PATH,5,-5152.449,-586.9136,397.4418,NULL,0,0,0,100,0),
(@PATH,6,-5136.8228,-594.1225,397.30118,NULL,0,0,0,100,0),
(@PATH,7,-5127.86,-593.34924,397.30118,NULL,0,0,0,100,0),
(@PATH,8,-5126.536,-586.53815,397.30118,NULL,0,0,0,100,0),
(@PATH,9,-5130.469,-588.1358,397.30118,NULL,0,0,0,100,20000),
(@PATH,10,-5131.538,-596.21716,397.30118,NULL,0,0,0,100,0),
(@PATH,11,-5152.9185,-587.6705,397.30118,NULL,0,0,0,100,0),
(@PATH,12,-5161.316,-577.31525,397.30118,NULL,0,0,0,100,0),
(@PATH,13,-5161.492,-570.673,397.30118,NULL,0,0,0,100,0),
(@PATH,14,-5158.0684,-569.75946,397.30118,NULL,0,0,0,100,0);
-- .go xyz -5179.5845 -554.1431 397.27936-- Pathing for Entry: 23504
SET @NPC := XXXXXX;
SET @PATH := @NPC * 10;
UPDATE `creature` SET `wander_distance`=0,`MovementType`=2,`position_x`=-5172.882,`position_y`=-622.4076,`position_z`=397.30118 WHERE `guid`=@NPC;
UPDATE `creature_addon` SET `path_id` = @PATH WHERE `guid` = @NPC;
DELETE FROM `waypoint_data` WHERE `id`=@PATH;
INSERT INTO `waypoint_data` (`id`,`point`,`position_x`,`position_y`,`position_z`,`orientation`,`delay`,`move_type`,`action`,`action_chance`,`wpguid`) VALUES
(@PATH,1,-5172.882,-622.4076,397.30118,NULL,0,0,0,100,10000),
(@PATH,2,-5153.764,-618.47894,398.19446,NULL,0,0,0,100,0),
(@PATH,3,-5143.7505,-617.6986,398.0995,NULL,0,0,0,100,0),
(@PATH,4,-5141.4756,-614.8408,398.0995,NULL,0,0,0,100,0),
(@PATH,5,-5135.3057,-591.59015,397.30118,NULL,0,0,0,100,15000),
(@PATH,6,-5142.6113,-632.1305,397.2245,NULL,0,0,0,100,60000),
(@PATH,7,-5149.8955,-618.4285,398.20056,NULL,0,0,0,100,0),
(@PATH,8,-5167.732,-619.2291,397.3063,NULL,0,0,0,100,0);
-- .go xyz -5172.882 -622.4076 397.30118There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Timers are a guess :C
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's the wrong column >:(
Oh you're right, im blind
…t-setup-ironforge-1
… due to waypoint moving) Co-authored-by: Gultask <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 6 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| INSERT INTO `smart_scripts` (`entryorguid`, `source_type`, `id`, `link`, `event_type`, `event_phase_mask`, `event_chance`, `event_flags`, `event_param1`, `event_param2`, `event_param3`, `event_param4`, `event_param5`, `event_param6`, `action_type`, `action_param1`, `action_param2`, `action_param3`, `action_param4`, `action_param5`, `action_param6`, `target_type`, `target_param1`, `target_param2`, `target_param3`, `target_param4`, `target_x`, `target_y`, `target_z`, `target_o`, `comment`) VALUES | ||
| (-12822, 0, 1000, 0, 108, 0, 100, 0, 1, 0, 0, 0, 0, 0, 17, 133, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 0, 'Brewfest Setup Crew - On Point 2 Reached - Set Emote State 234'), | ||
| (-12822, 0, 1001, 0, 108, 0, 100, 0, 2, 0, 0, 0, 0, 0, 17, 0, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 0, 'Brewfest Setup Crew - On Point 3 Reached - Reset EmoteState'), | ||
| (-12822, 0, 1002, 0, 108, 0, 100, 0, 6, 0, 0, 0, 0, 0, 17, 133, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 0, 'Brewfest Setup Crew - On Point 6 Reached - Set Emote State 234'), |
Copilot
AI
Jan 30, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment says "Set Emote State 234" but the action_param1 is 133, not 234. The emote state value should match what's described in the comment.
| (-12822, 0, 1002, 0, 108, 0, 100, 0, 6, 0, 0, 0, 0, 0, 17, 133, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 0, 'Brewfest Setup Crew - On Point 6 Reached - Set Emote State 234'), | ||
| (-12822, 0, 1003, 0, 108, 0, 100, 0, 7, 0, 0, 0, 0, 0, 17, 0, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 0, 'Brewfest Setup Crew - On Point 7 Reached - Reset EmoteState'), | ||
| (-12822, 0, 1004, 0, 108, 0, 100, 0, 8, 0, 0, 0, 0, 0, 17, 133, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 0, 'Brewfest Setup Crew - On Point 8 Reached - Set Emote State 234'), |
Copilot
AI
Jan 30, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment says "Set Emote State 234" but the action_param1 is 133, not 234. The emote state value should match what's described in the comment.
| (-12822, 0, 1002, 0, 108, 0, 100, 0, 6, 0, 0, 0, 0, 0, 17, 133, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 0, 'Brewfest Setup Crew - On Point 6 Reached - Set Emote State 234'), | |
| (-12822, 0, 1003, 0, 108, 0, 100, 0, 7, 0, 0, 0, 0, 0, 17, 0, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 0, 'Brewfest Setup Crew - On Point 7 Reached - Reset EmoteState'), | |
| (-12822, 0, 1004, 0, 108, 0, 100, 0, 8, 0, 0, 0, 0, 0, 17, 133, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 0, 'Brewfest Setup Crew - On Point 8 Reached - Set Emote State 234'), | |
| (-12822, 0, 1002, 0, 108, 0, 100, 0, 6, 0, 0, 0, 0, 0, 17, 234, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 0, 'Brewfest Setup Crew - On Point 6 Reached - Set Emote State 234'), | |
| (-12822, 0, 1003, 0, 108, 0, 100, 0, 7, 0, 0, 0, 0, 0, 17, 0, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 0, 'Brewfest Setup Crew - On Point 7 Reached - Reset EmoteState'), | |
| (-12822, 0, 1004, 0, 108, 0, 100, 0, 8, 0, 0, 0, 0, 0, 17, 234, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 0, 'Brewfest Setup Crew - On Point 8 Reached - Set Emote State 234'), |
| INSERT INTO `smart_scripts` (`entryorguid`, `source_type`, `id`, `link`, `event_type`, `event_phase_mask`, `event_chance`, `event_flags`, `event_param1`, `event_param2`, `event_param3`, `event_param4`, `event_param5`, `event_param6`, `action_type`, `action_param1`, `action_param2`, `action_param3`, `action_param4`, `action_param5`, `action_param6`, `target_type`, `target_param1`, `target_param2`, `target_param3`, `target_param4`, `target_x`, `target_y`, `target_z`, `target_o`, `comment`) VALUES | ||
| (-12828, 0, 1000, 0, 108, 0, 100, 0, 2, 0, 0, 0, 0, 0, 17, 234, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 0, 'Brewfest Setup Crew - On Point 2 Reached - Set Emote State 234'), | ||
| (-12828, 0, 1001, 0, 108, 0, 100, 0, 3, 0, 0, 0, 0, 0, 17, 0, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 0, 'Brewfest Setup Crew - On Point 3 Reached - Reset EmoteState'), | ||
| (-12828, 0, 1002, 0, 108, 0, 100, 0, 4, 0, 0, 0, 0, 0, 17, 234, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 0, 'Brewfest Setup Crew - On Point 2 Reached - Set Emote State 234'), |
Copilot
AI
Jan 30, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment on line 238 says "On Point 2 Reached" but the event_param1 is 4, meaning this triggers on Point 4, not Point 2. The waypoint point numbers should match the event_param1 values in the comments.
| (-12828, 0, 1002, 0, 108, 0, 100, 0, 4, 0, 0, 0, 0, 0, 17, 234, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 0, 'Brewfest Setup Crew - On Point 2 Reached - Set Emote State 234'), | |
| (-12828, 0, 1002, 0, 108, 0, 100, 0, 4, 0, 0, 0, 0, 0, 17, 234, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 0, 'Brewfest Setup Crew - On Point 4 Reached - Set Emote State 234'), |
|
|
||
| DELETE FROM `smart_scripts` WHERE (`source_type` = 0 AND `entryorguid` = -12821); | ||
| INSERT INTO `smart_scripts` (`entryorguid`, `source_type`, `id`, `link`, `event_type`, `event_phase_mask`, `event_chance`, `event_flags`, `event_param1`, `event_param2`, `event_param3`, `event_param4`, `event_param5`, `event_param6`, `action_type`, `action_param1`, `action_param2`, `action_param3`, `action_param4`, `action_param5`, `action_param6`, `target_type`, `target_param1`, `target_param2`, `target_param3`, `target_param4`, `target_x`, `target_y`, `target_z`, `target_o`, `comment`) VALUES | ||
| (-12821, 0, 1000, 0, 108, 0, 100, 0, 2, 0, 0, 0, 0, 0, 17, 133, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 0, 'Brewfest Setup Crew - On Point 2 Reached - Set Emote State 234'), |
Copilot
AI
Jan 30, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment says "Set Emote State 234" but the action_param1 is 133, not 234. The emote state value should match what's described in the comment. This same issue appears on lines 268, 291, 293, and 295.
| INSERT INTO `smart_scripts` (`entryorguid`, `source_type`, `id`, `link`, `event_type`, `event_phase_mask`, `event_chance`, `event_flags`, `event_param1`, `event_param2`, `event_param3`, `event_param4`, `event_param5`, `event_param6`, `action_type`, `action_param1`, `action_param2`, `action_param3`, `action_param4`, `action_param5`, `action_param6`, `target_type`, `target_param1`, `target_param2`, `target_param3`, `target_param4`, `target_x`, `target_y`, `target_z`, `target_o`, `comment`) VALUES | ||
| (-12821, 0, 1000, 0, 108, 0, 100, 0, 2, 0, 0, 0, 0, 0, 17, 133, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 0, 'Brewfest Setup Crew - On Point 2 Reached - Set Emote State 234'), | ||
| (-12821, 0, 1001, 0, 108, 0, 100, 0, 3, 0, 0, 0, 0, 0, 17, 0, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 0, 'Brewfest Setup Crew - On Point 3 Reached - Reset EmoteState'), | ||
| (-12821, 0, 1002, 0, 108, 0, 100, 0, 10, 0, 0, 0, 0, 0, 17, 133, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 0, 'Brewfest Setup Crew - On Point 10 Reached - Set Emote State 234'), |
Copilot
AI
Jan 30, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment says "Set Emote State 234" but the action_param1 is 133, not 234. The emote state value should match what's described in the comment.
|
|
||
| DELETE FROM `smart_scripts` WHERE (`source_type` = 0 AND `entryorguid` = -12822); | ||
| INSERT INTO `smart_scripts` (`entryorguid`, `source_type`, `id`, `link`, `event_type`, `event_phase_mask`, `event_chance`, `event_flags`, `event_param1`, `event_param2`, `event_param3`, `event_param4`, `event_param5`, `event_param6`, `action_type`, `action_param1`, `action_param2`, `action_param3`, `action_param4`, `action_param5`, `action_param6`, `target_type`, `target_param1`, `target_param2`, `target_param3`, `target_param4`, `target_x`, `target_y`, `target_z`, `target_o`, `comment`) VALUES | ||
| (-12822, 0, 1000, 0, 108, 0, 100, 0, 1, 0, 0, 0, 0, 0, 17, 133, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 0, 'Brewfest Setup Crew - On Point 2 Reached - Set Emote State 234'), |
Copilot
AI
Jan 30, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment says "Set Emote State 234" but the action_param1 is 133, not 234. The emote state value should match what's described in the comment.
Changes Proposed:
This PR proposes changes to:
AI-assisted Pull Requests
Important
While the use of AI tools when preparing pull requests is not prohibited, contributors must clearly disclose when such tools have been used and specify the model involved.
Contributors are also expected to fully understand the changes they are submitting and must be able to explain and justify those changes when requested by maintainers.
Issues Addressed:
SOURCE:
The changes have been validated through:
Tests Performed:
This PR has been:
How to Test the Changes:
.event start 70.go ga 3839Known Issues and TODO List:
How to Test AzerothCore PRs
When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].
You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:
http://www.azerothcore.org/wiki/How-to-test-a-PR
REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).
For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.