fix(Scripts/IcecrownCitadel): Exclude totems and non-players from Val’kyr target search

[mehdikhody]

This PR addresses an issue in the Icecrown Citadel Lich King encounter where Val'kyr Shadowguards can select invalid targets such as Shaman totems or other non-player units during Phase 2.

Blizzlike behavior requires Val'kyr to only pick living player characters as grab targets. Currently, generic friendly-unit selection allows totems (Creature type CREATURE_TYPE_TOTEM) and other non-player units to be included in the target pool, resulting in failed grabs or unintended behavior.

Changes Proposed:

This PR proposes changes to:

• Core (units, players, creatures, game systems).
• Scripts (bosses, spell scripts, creature scripts).
• Database (SAI, creatures, etc).

Details:

• Filter out Creature-type totems (CREATURE_TYPE_TOTEM) from Val'kyr candidate target list.
• Enforce TYPEID_PLAYER as a final target requirement.
• Result: Val'kyr only select living player characters as intended.

SOURCE:

ICC Phase 2 Val'kyr pickup behavior is documented through retail encounter videos and raid guides indicating player-only target selection.

Tests Performed:

This PR has been:

• Tested in-game by the author.
• Tested in-game by other community members/someone else other than the author/has been live on production servers.
• This pull request requires further testing and may have edge cases to be tested.

Testing notes:

• Verified Val'kyr ignored totems.
• Verified Val'kyr only selected players.
• Verified no errors during build or runtime.

How to Test the Changes:

This issue is a rare occurrence, but it has happened multiple times across several test servers, and players have filed complaints when Val'kyr attempted to grab totems or other non-player units instead of players. For that reason, reproducibility may vary, and extended encounter testing is recommended.

1. Enter ICC and start the Lich King encounter.
2. Reach Phase 2 when Val'kyr spawn.
3. Have a Shaman in the raid place totems, and optionally include pets/guardians.
4. Observe target selection during Val'kyr grab attempts.
5. Expected: Val'kyr only target players and ignore totems and all other non-player units.
6. Repeat multiple pulls to ensure no edge cases occur.

[Nyeriah]

Well, it is just wrong.

1. this will prevent summons from ever attacking anything other than a player, pets included
2. the valkyr search spell already only targets players
3. Is this an AI deduction?

[mehdikhody]

On my private server, I tested this encounter with three different guilds, and they all reported the same problem with Valkyr dragging players. In some instances, the Valkyr chooses no player and flies to the platform's edge (some reports claim it targets Shaman totems). They also noticed that ghouls and shambling horrors begin attacking pets and totems and cannot be taunted. Several guilds asked for a fix because this was a regular occurrence in heroic mode.

Because the first raging spirit descends and reappears later in phase 3, I have also extended the raging spirit summon timer during the second transition. That problem was fixed by raising the timer by two seconds.

Since this patch has been requested numerous times, I wanted to give it back to the community.
I appreciate all of your hard work.

[EricksOliveira]

I believe the Lich King boss script isn't wrong. The error occurred in an update that was done some time ago. I applied a fix and it worked fine for me, but it needs further testing. #24109

[mehdikhody]

I believe the Lich King boss script isn't wrong. The error occurred in an update that was done some time ago. I applied a fix and it worked fine for me, but it needs further testing. #24109

I appreciate you telling me. This explains why totems and pets are attacked by ghouls and shambling horrors when they respawn. Does it, however, also resolve the Raging Spirits' descent into the ground during the second transition and subsequent rise in Phase 3?

How about Valkyr grabbing totems? I no longer know exactly what the bug is. I've heard multiple types of explanations.
Some claim it's because the Valkyr picks up a totem or pet, while others say the Valkyr charges a player before moving to the edge without grabbing anyone.

I'm sure my solution isn't perfect, but you get the idea.

As of right now, it has resolved the issue for both the players and me, so more research is worthwhile.
This is the main encounters in the entire game.

I can put this on hold while I look into it more, but it obviously needed to be fixed.
I appreciate all of your insights.