Conversation
Collaborator
🟡 Heimdall Review Status
|
refcell
reviewed
Feb 4, 2026
refcell
reviewed
Feb 4, 2026
refcell
reviewed
Feb 4, 2026
refcell
reviewed
Feb 4, 2026
Comment on lines
86
to
95
| fn assert_load_test_passed(stats: &Stats) { | ||
| assert!( | ||
| stats.submitted() >= 10, | ||
| "Expected at least 10 transactions to be submitted, got {}", | ||
| stats.submitted() | ||
| ); | ||
| // TODO: once the resource metering changes are in, we should have different | ||
| // thresholds for failed transactions | ||
| assert!(stats.failed() <= 2, "Expected no more than 2 failed transactions, but {} failed", stats.failed()); | ||
| } |
Contributor
There was a problem hiding this comment.
We should open up a ticket to track this. Generally would be nice to not commit TODOs into the codebase but at the minimum have tickets to track.
refcell
reviewed
Feb 4, 2026
refcell
reviewed
Feb 4, 2026
Contributor
refcell
left a comment
There was a problem hiding this comment.
Few nits but otherwise good to merge
Collaborator
|
I think we should put load tests into base/infra. A few thoughts:
I think we need a bit of a plan to unify contender, this PR and gobrr. Lets chat on Monday and come up with a plan |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #653
Motivation
Previously, there wasn't a way to easily test changes made across our services. We would deploy to the devnet and manually QA. As part of the production readiness of getting resource metering out, it's a requirement to be able to run the system locally and test locally first before rolling out changes.
Changes
This PR extends off of the
system_testswhich was originally inspired byscripts/devnet/to include stress/load tests. It includes bringing in theSimulator.solcontract frombase/benchmarkand sending transactions that would be gas or time expensive (see storage slot modifications, calldata sizes)Notes
load.rsto purposefully include transactions that would be rejected by the builder to test if the e2e behaviour works.Co-authored-by: Niran Babalola niran.babalola@coinbase.com