Skip to content

chore(builder): simplify builder setup to match node#678

Draft
danyalprout wants to merge 2 commits intodanyal/remove-launch-logicfrom
danyal/simplify-builder-setup
Draft

chore(builder): simplify builder setup to match node#678
danyalprout wants to merge 2 commits intodanyal/remove-launch-logicfrom
danyal/simplify-builder-setup

Conversation

@danyalprout
Copy link
Collaborator

@danyalprout danyalprout commented Feb 7, 2026

Description

Note

Stacked on top of #681

This is part one of #677

  • Move builder cli args to binary (similar to base-node)
  • Drop the telemetry stuff (I'm assuming this should work off the env vars based on Backport tracing to 0.4.0 #675)
    • I kept the sampling ratio, as this is probably very useful for the builder
  • Simplified the init macros into init_common (all programs), init_reth
  • Move the node setup into main.rs (this is temporary and will be mitigated in follow up PRs)
  • Misc lychee path fix

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Feb 7, 2026

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@danyalprout danyalprout force-pushed the danyal/simplify-builder-setup branch from 6af0e12 to 6d545b9 Compare February 8, 2026 10:22
@danyalprout danyalprout changed the base branch from main to danyal/remove-launch-logic February 8, 2026 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants