Revert "Configure Lexxy to add extra spacing between block elements"#2695
Revert "Configure Lexxy to add extra spacing between block elements"#2695flavorjones merged 1 commit intomainfrom
Conversation
This reverts commit d6bf103.
There was a problem hiding this comment.
Pull request overview
Updates the project’s Lexxy dependency to pull directly from the Basecamp GitHub repository and removes a Lexxy markdown-paste initializer from the JavaScript initializer bundle.
Changes:
- Switch Lexxy from a pinned gem version to a
bc:git source (and update both lockfiles accordingly). - Remove the
lexxy_markdown_pasteinitializer and stop importing it fromapp/javascript/initializers/index.js.
Reviewed changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Gemfile | Switch Lexxy dependency to bc: git source. |
| Gemfile.lock | Lock Lexxy to a specific git revision and update dependency entry to lexxy!. |
| Gemfile.saas.lock | Mirror the Lexxy git lock changes for the SaaS lockfile. |
| app/javascript/initializers/lexxy_markdown_paste.js | Remove the Lexxy markdown paste event handler. |
| app/javascript/initializers/index.js | Stop importing the removed Lexxy markdown paste initializer. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
| @@ -1,4 +1,3 @@ | |||
| import "initializers/current" | |||
| import "initializers/bridge/bridge_element" | |||
| import "initializers/offline" | |||
There was a problem hiding this comment.
This change drops the Lexxy markdown-paste initializer from the initializer bundle. A repo-wide search shows there are no remaining listeners for the "lexxy:insert-markdown" event / "addBlockSpacing", so the previous markdown paste block-spacing behavior is now entirely gone. If that behavior is still desired, reintroduce the handler (or ensure the new Lexxy revision provides an equivalent built-in).
| import "initializers/offline" | |
| import "initializers/offline" | |
| import "initializers/lexxy_markdown_paste" |
This reverts commit d6bf103 due to some issues in Lexxy 0.8.0.