Add len_u16 and len_u8 features to change the type of LenUint#248
Open
WuBingzheng wants to merge 1 commit intobluss:masterfrom
Open
Add len_u16 and len_u8 features to change the type of LenUint#248WuBingzheng wants to merge 1 commit intobluss:masterfrom
WuBingzheng wants to merge 1 commit intobluss:masterfrom
Conversation
|
This should not be a feature, as features should be entirely additive. I would recommend making it a generic, maybe? |
Author
|
I do not know how to make it a generic. Use the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
len_u16andlen_u8features to change the type ofLenUint.Using
u8asLenUintsaves 3 bytes. This is useful for many really small strings.